Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align wrong/missing permissions messages on Management UI #35796

Closed
markov00 opened this issue Apr 30, 2019 · 11 comments
Closed

Align wrong/missing permissions messages on Management UI #35796

markov00 opened this issue Apr 30, 2019 · 11 comments
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. usability

Comments

@markov00
Copy link
Member

Each page in Management UI has a different way to say that the logged in user doesn't have the right privileges to modify/see that page.

From a better usability, I think we should provide a unique way to inform the user about that, using an aligned view to describe the problem and give a possible solution.

We are also calling the same thing in various ways: permission denied, access denied
missing privileges, missing sufficient privileges, unauthorized.

The following list shows some screenshot taken from demo.elastic.co management page for a guest user:

users:
Screenshot 2019-04-30 at 13 59 26

roles:
Screenshot 2019-04-30 at 13 59 32

index management:
Screenshot 2019-04-30 at 13 59 36

index lifecycle policies:
Screenshot 2019-04-30 at 13 59 44

upgrade assistant:
Screenshot 2019-04-30 at 14 00 25

Spaces:
Screenshot 2019-04-30 at 14 00 53

Logstash pipeline:
Screenshot 2019-04-30 at 14 01 17

Beats:
Screenshot 2019-04-30 at 14 01 24

Some page use the EuiEmptyPrompt that seems a good way to implement this unauthorized message prompt.

@elastic/eui-design what do you think about?

@markov00 markov00 added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. usability Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Apr 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@ryankeairns
Copy link
Contributor

Adding the docs team to assist with sorting out the preferred terminology.

@gjones
Copy link

gjones commented Apr 30, 2019

Oh interesting, in Cloud we're added a few similar pages for the RBAC project, I wonder if we can agree on a standard and create a component for it, similar to euiTable empty state. cc @pugnascotia @webfella

@pugnascotia
Copy link
Contributor

Agreed, maybe this is at least worth documenting as a pattern in EUI. Cloud is mostly disabling buttons with a tooltip that explains why.

@cchaos
Copy link
Contributor

cchaos commented Apr 30, 2019

For Kibana specifically, we agree that we need a standard pattern for whole plugins/sections being disabled because of permissions (though it also seems like something that should maybe be completely hidden from that user -- no item in the management side nav).

One of the quirks we're dealing with right now is the mix of Angular code still floating in those pages. For instance, I believe the Roles listing page is still Angular (which is why that callout looks different from all the rest). So in order to make them all the same, we'll also need to make sure all the pages are React.

@snide
Copy link
Contributor

snide commented Apr 30, 2019

Let's start with a guideline in EUI. End of day a lot of this stuff happens because the teams that are working on them are different and they're just making their own calls. The screens above represent 4 floating teams (security, elastic ui, ingest, ops).

People have been asking for more guidelines. Seems as good a one to start as any.

@schersh
Copy link
Contributor

schersh commented May 1, 2019

@gchaps and I are happy to help with the wording in these messages, once we know which components we're going to recommend in the guidelines.

@cjcenizal cjcenizal added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jun 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@legrego
Copy link
Member

legrego commented Sep 22, 2020

This is likely resolved now that #67791 has merged -- most of these privilege messages are obsolete now that management sections hide themselves to unauthorized users.

@cjcenizal
Copy link
Contributor

Fixed by #67791. Let's open new individual issues as we uncover outstanding edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. usability
Projects
None yet
Development

No branches or pull requests