Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Guidelines to add to the docs #1899

Closed
2 of 13 tasks
snide opened this issue Apr 30, 2019 · 2 comments
Closed
2 of 13 tasks

[META] Guidelines to add to the docs #1899

snide opened this issue Apr 30, 2019 · 2 comments
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries meta

Comments

@snide
Copy link
Contributor

snide commented Apr 30, 2019

As part of our internal EUI satisfaction survey we got a pretty consistent request to add more guidelines to EUI. Here are some topics of common patterns where we see irregularity when a designer is not directly involved in the project.

If you run into confusion in EUI, please leave a comment and add a suggestion and we'll adjust the list. This will become more of a priority with our team as the library continues to mature.

@snide snide added documentation Issues or PRs that only affect documentation - will not need changelog entries meta labels Apr 30, 2019
@snide snide changed the title Guidelines to add to the docs [META] Guidelines to add to the docs Apr 30, 2019
@ryankeairns
Copy link
Contributor

ryankeairns commented Nov 6, 2020

A recent Slack chat led us to summarize form validation as follow:

  • Focus on first item
  • Validate format/syntax onBlur (preferred over onChange so as to avoid validation errors as you start typing your initial input)
  • Validate required fields onSubmit
  • Don’t disable the button (screen readers may bypass it; if you can't click, you can't see what's remaining)

@cchaos
Copy link
Contributor

cchaos commented Mar 19, 2021

I've added each of these bullet points to the Guidelines column of the Documentation project. I find this organization easier to track.

@cchaos cchaos closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries meta
Projects
None yet
Development

No branches or pull requests

3 participants