Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Viz type selection button should read more clearly in screenreader #29475

Closed
bhavyarm opened this issue Jan 28, 2019 · 3 comments
Assignees
Labels
discuss enhancement New value added to drive a business result Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A

Comments

@bhavyarm
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

  1. Use keyboard and voiceover and open visualize app and
  2. click on create visualization button or on plus sign

area_button_meny

co-ordinate_map_button

Actual Result

  1. Screenreader reads are area button, co-ordinator map button

Expected Result

  1. Screenreader can read create area chart...create input controls etc instead of reading the button

Meta Issue
#28599

Kibana Version: 6.6.0 BC9

Relevant WCAG Criteria: [#.#.# WCAG Criterion](link to https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0)

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes
Copy link
Contributor

timroes commented Jan 29, 2019

I would actually recommend not doing that, for a specific reason. We could easily rename every button in Create {vistype} visualization. I (a) don't think it's necessary, because the user is already in the New visualization dialog, and selected a button to create a new visualization already, so I think that additional context is not needed and more important (b) I've seen blind users often use their screen reader in a way, that they use the link search to navigate through that kind of link lists efficiently. If we suddenly make all links start with the same word and such the same character, you cannot easily use that feature anymore to press P to jump directly to the pie chart link.

So my suggestion would be, leaving that as it is with just the vis type name as a label, but I am happy to hear more opinions on that topic.

@timroes timroes added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Jan 29, 2019
@PhilippBaranovskiy PhilippBaranovskiy self-assigned this Mar 14, 2019
@PhilippBaranovskiy
Copy link
Contributor

@bhavyarm, now the screen reader explains what Coordinate Map means/does if you choose the option.
For instance, it "plots latitude and longitude coordinates on a map" screen reader says.

1: That was added by @timroes by that commit: b172649f347
I agree with Tim's thought that unique first word provides a possibility for a quick jump by a keyboard.
I suggest that we should leave it as it is now.

2: On the other hand, when a user press "create a new visualization" button, the popover opens and auto-focuses, -- at the moment the popover gets auto-focus no annoncement is out there.
I suggest that I should place an aria-label with some explanation on it.

How does it sound? What do you think?

cc @rayafratkina

Capture

PhilippBaranovskiy added a commit that referenced this issue Mar 28, 2019
… screenreader #29475 (#33434)

* popover announces itself, button gives predictable behavior; menutitems
* drops incorrect button aria label
* replace aria-describedby with translated label
PhilippBaranovskiy added a commit to PhilippBaranovskiy/kibana that referenced this issue Mar 28, 2019
… screenreader elastic#29475 (elastic#33434)

* popover announces itself, button gives predictable behavior; menutitems
* drops incorrect button aria label
* replace aria-describedby with translated label
PhilippBaranovskiy added a commit that referenced this issue Mar 28, 2019
… screenreader #29475 (#33434) (#34034)

* popover announces itself, button gives predictable behavior; menutitems
* drops incorrect button aria label
* replace aria-describedby with translated label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A
Projects
None yet
Development

No branches or pull requests

5 participants