-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Linking to Infra and Logging UIs #26574
Comments
Pinging @elastic/apm-ui |
@makwarth we had a question about the logic for showing which link? Do we just show any of the links above if there is data for the associated value present and hide otherwise, or are there some links that should not be shown for other reasons (e.g. don't show the host logs link if kubernetes.pod.uid is found, or things of that nature)? |
an example: if there's no |
This ended up being a longer reply that anticipated. Here goes: I think it's important that the links are always shown, so that they don't "randomly" disappear. I agree with the concern and it's not a great solution to knowingly link to a "no results" page. However, this is generally how Kibana (and other tools) work already. For example, the time picker won't indicate, if there's data or not before navigating to a range. Similarly, visualize won't stop you from doing an aggregation that leads to no results. Showing good documentation on "no results" pages is a standard and scalable solution, imo. Having said all that, we could look into greying links out, if they don't link to a meaningful value. Question then becomes: How do we inform the user about why some links are greyed out? We'd need a tooltip, or similar, with copy and/or a link to documentation. If possible, having greyed out links with good tooltips is probably the ideal solution, but it also requires more work and maintenance. If this is doable before 6.6, I'm all for upping the polish on this issue, but I'm also good with shipping as is and iterating after. |
I'm worried the user will very quickly lose faith in the feature, if they get used to seeing "No results" when clicking a link. I therefore think greying out the links is a must-have in the first iteration - it also shouldn't be difficult to add. |
How difficult will it be to detect "meaningful value"? How likely is it that e.g. |
generally, if there's a value we should show the link. As far as I can tell, there's little chance of the data being there but incorrect. |
Ok, that's easier than I expected 👍 I'll update the description |
…saction to the Infra & Logging UIs
* [APM] fixes #26574 by adding an Action menu which links a transaction to the Infra & Logging UIs * [APM] - remove link to host metrics filterd by trace id until supported - replace ts-optchain with _.get - remove old, unreferenced ActionMenu dead code - add unit tests * [APM] Make sure the apm index pattern filter is passed thru via the Discover link * [APM] refactored DiscoverButton and TransactionActionMenu to use new QueryWithIndexPattern component to pass along the correct index pattern via the discover link
…7291) * [APM] fixes elastic#26574 by adding an Action menu which links a transaction to the Infra & Logging UIs * [APM] - remove link to host metrics filterd by trace id until supported - replace ts-optchain with _.get - remove old, unreferenced ActionMenu dead code - add unit tests * [APM] Make sure the apm index pattern filter is passed thru via the Discover link * [APM] refactored DiscoverButton and TransactionActionMenu to use new QueryWithIndexPattern component to pass along the correct index pattern via the discover link
…27445) * [APM] fixes #26574 by adding an Action menu which links a transaction to the Infra & Logging UIs * [APM] - remove link to host metrics filterd by trace id until supported - replace ts-optchain with _.get - remove old, unreferenced ActionMenu dead code - add unit tests * [APM] Make sure the apm index pattern filter is passed thru via the Discover link * [APM] refactored DiscoverButton and TransactionActionMenu to use new QueryWithIndexPattern component to pass along the correct index pattern via the discover link
This is a new implementation issue for #26326 and what we discussed around 6.5.
Handy: 6.5 implementation issue #23315 and the removal issue #24562
Motivation
We're bringing back the integration links in 6.6.
For when these links result in jumping to another solution with no results (due to the above complications) we'll update the no page-message to include a troubleshooting guide.
Update: We've decided to deactivate any links that links to a null value. We need some way of letting the user know why some links are greyed out. (e.g. tooltip with link to docs)
Cross-solution links
trace.id
kubeternetes.pod.uid
container.id
host.name
kubeternetes.pod.uid
container.id
host.name
[icon]: Solution icon of app that we're linking to.
Deep-linking URLs: #23315 (comment)
Troubleshooting link
Links from Infra and Logging will drop into
/app/apm#/services/
with atrace.id :
query, so we should add our troubleshooting link here.The text was updated successfully, but these errors were encountered: