Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Migrate Anomaly Explorer Swimlanes from angularjs/jquery to React/d3 #22642

Closed
9 tasks done
walterra opened this issue Sep 4, 2018 · 1 comment
Closed
9 tasks done

[ML] Migrate Anomaly Explorer Swimlanes from angularjs/jquery to React/d3 #22642

walterra opened this issue Sep 4, 2018 · 1 comment
Assignees
@walterra
Labels
Feature:Anomaly Detection ML anomaly detection Meta :ml refactoring

Comments

@walterra
Copy link
Contributor

walterra commented Sep 4, 2018 •
edited
Loading

Bugs

Part of #18374 and #18553.
@walterra walterra self-assigned this Sep 4, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@walterra walterra added the Meta label Sep 4, 2018
This was referenced Sep 4, 2018
Merged
Merged
walterra added a commit that referenced this issue Sep 11, 2018
@walterra
[ML] Fixes Anomaly Explorer Swimlane race condition, adds tests. (#22814
7de9f69 
)

This PR addresses parts of #22642:
- It gets rid of the use of var that = this;.
- dragSelect's action strings are moved to a constants file.
- Adds jest tests for the ExplorerSwimlane component.

This also fixes the following bugs:
- The way we subscribe listeners to the events of the dragSelect library could result in the same event being triggered multiple times. This in turn could cause race conditions when on each event new data gets fetched but in between angular's scope gets updated and could end up in a non-intended way. The result of this were view-by swimlanes not updating correctly or anomaly charts showing non-related charts. This PR fixes it by filtering out consecutive swimlane click events.
- When the angular based chart container wrapper directive gets destroyed/re-esetup when using the job pick, it missed unmounting the react component, it didn't trigger componentWillUnmount()and didn't unsubscribe from dragSelectListener.
walterra added a commit to walterra/kibana that referenced this issue Sep 11, 2018
@walterra
[ML] Fixes Anomaly Explorer Swimlane race condition, adds tests. (ela…
d9bcff6 
…stic#22814)

This PR addresses parts of elastic#22642:
- It gets rid of the use of var that = this;.
- dragSelect's action strings are moved to a constants file.
- Adds jest tests for the ExplorerSwimlane component.

This also fixes the following bugs:
- The way we subscribe listeners to the events of the dragSelect library could result in the same event being triggered multiple times. This in turn could cause race conditions when on each event new data gets fetched but in between angular's scope gets updated and could end up in a non-intended way. The result of this were view-by swimlanes not updating correctly or anomaly charts showing non-related charts. This PR fixes it by filtering out consecutive swimlane click events.
- When the angular based chart container wrapper directive gets destroyed/re-esetup when using the job pick, it missed unmounting the react component, it didn't trigger componentWillUnmount()and didn't unsubscribe from dragSelectListener.
walterra added a commit that referenced this issue Sep 11, 2018
@walterra
[ML] Fixes Anomaly Explorer Swimlane race condition, adds tests. (#22814
704667f 
) (#22923)

This PR addresses parts of #22642:
- It gets rid of the use of var that = this;.
- dragSelect's action strings are moved to a constants file.
- Adds jest tests for the ExplorerSwimlane component.

This also fixes the following bugs:
- The way we subscribe listeners to the events of the dragSelect library could result in the same event being triggered multiple times. This in turn could cause race conditions when on each event new data gets fetched but in between angular's scope gets updated and could end up in a non-intended way. The result of this were view-by swimlanes not updating correctly or anomaly charts showing non-related charts. This PR fixes it by filtering out consecutive swimlane click events.
- When the angular based chart container wrapper directive gets destroyed/re-esetup when using the job pick, it missed unmounting the react component, it didn't trigger componentWillUnmount()and didn't unsubscribe from dragSelectListener.
@walterra walterra mentioned this issue Sep 13, 2018
Merged
@walterra walterra changed the title [ML] Migrate Anomaly Explorer Swimlanes to React [ML] Migrate Anomaly Explorer Swimlanes from angularjs/jquery to React/d3 Sep 14, 2018
This was referenced Sep 18, 2018
Merged
Merged
@walterra walterra mentioned this issue Sep 28, 2018
Merged
@walterra walterra mentioned this issue Jan 24, 2019
Open
42 tasks
@sophiec20 sophiec20 added Feature:Anomaly Detection ML anomaly detection and removed Feature:ml-results legacy - do not use labels Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walterra walterra

Labels
Feature:Anomaly Detection ML anomaly detection Meta :ml refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@walterra @sophiec20 @elasticmachine