Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Export Everything" does not properly constrain saved object types #21416

Closed
legrego opened this issue Jul 30, 2018 · 0 comments
Closed

"Export Everything" does not properly constrain saved object types #21416

legrego opened this issue Jul 30, 2018 · 0 comments
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@legrego
Copy link
Member

legrego commented Jul 30, 2018

Kibana version: 6.4

Describe the bug:
Clicking "Export Everything" from the Saved Objects Management screen should export all saved objects of specific types. The type filtering is not being applied correctly, which results in ALL saved objects being exported (including, for example, the config object). This appears to be a regression introduced with #17426
@legrego legrego added bug Fixes for quality problems that affect the customer experience :Management labels Jul 30, 2018
This was referenced Jul 30, 2018
Merged
Merged
legrego added a commit that referenced this issue Jul 31, 2018
@legrego
Fix "export everything" (#21434)
430ad15 
Fixes #21416 - this is identical to #21402, but adds testing to prevent a regression.

@chrisronline in the interest of speed, time, and stability for 6.4, I opted not to do a full functional test, but rather an API test to ensure that the API endpoint was interacting with the Saved Objects Client as expected.
legrego added a commit to legrego/kibana that referenced this issue Jul 31, 2018
@legrego
Fix "export everything" (elastic#21434)
c8ead9e 
Fixes elastic#21416 - this is identical to elastic#21402, but adds testing to prevent a regression.

@chrisronline in the interest of speed, time, and stability for 6.4, I opted not to do a full functional test, but rather an API test to ensure that the API endpoint was interacting with the Saved Objects Client as expected.
legrego added a commit to legrego/kibana that referenced this issue Jul 31, 2018
@legrego
Fix "export everything" (elastic#21434)
70c672b 
Fixes elastic#21416 - this is identical to elastic#21402, but adds testing to prevent a regression.

@chrisronline in the interest of speed, time, and stability for 6.4, I opted not to do a full functional test, but rather an API test to ensure that the API endpoint was interacting with the Saved Objects Client as expected.
legrego added a commit that referenced this issue Jul 31, 2018
@legrego
Fix "export everything" (#21434) (#21458)
8ca8ed5 
Fixes #21416 - this is identical to #21402, but adds testing to prevent a regression.

@chrisronline in the interest of speed, time, and stability for 6.4, I opted not to do a full functional test, but rather an API test to ensure that the API endpoint was interacting with the Saved Objects Client as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@legrego