Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Cases] Fix unit tests for React@18 #206954

Closed
cnasikas opened this issue Jan 16, 2025 · 1 comment · Fixed by #207072
Closed

[ResponseOps][Cases] Fix unit tests for React@18 #206954

cnasikas opened this issue Jan 16, 2025 · 1 comment · Fixed by #207072
Assignees
@georgianaonoleata1904
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) testing Issues related to tests.

Comments

@cnasikas
Copy link
Member

Based on this issue #206952, we need to fix a test that fails in React 18. Instructions can be found in the issue.

Test:

[job] [logs] Jest Tests / ConnectorForm calls onChange when the form is invalid @elastic/response-ops
@cnasikas cnasikas added Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) testing Issues related to tests. labels Jan 16, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas mentioned this issue Jan 16, 2025
Closed
5 tasks
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 22, 2025
@georgianaonoleata1904
[ResponseOps][Cases]Fix unit tests for React@18 (elastic#207072)
30f9766 
Closes elastic#206954

## Summary

- fixed

-
[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/267663#01946e9c-d647-4af9-9e61-586deed1bcfb)
[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/267663/jobs/01946e9c-d647-4af9-9e61-586deed1bcfb/artifacts/01946ec2-e5bc-40be-98f8-d9fec8226ede)
Jest Tests / ConnectorForm calls onChange when the form is invalid

(cherry picked from commit f4ff699)
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@georgianaonoleata1904 @viduni94
[ResponseOps][Cases]Fix unit tests for React@18 (elastic#207072)
0f038dc 
Closes elastic#206954

## Summary

- fixed

-
[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/267663#01946e9c-d647-4af9-9e61-586deed1bcfb)
[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/267663/jobs/01946e9c-d647-4af9-9e61-586deed1bcfb/artifacts/01946ec2-e5bc-40be-98f8-d9fec8226ede)
Jest Tests / ConnectorForm calls onChange when the form is invalid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgianaonoleata1904 georgianaonoleata1904

Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) testing Issues related to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps][Cases]Fix unit tests for React@18 georgianaonoleata1904/kibana
3 participants
@cnasikas @elasticmachine @georgianaonoleata1904