Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] - Add "Copy" action/button for field values once fields are selected in Discover. #203550

Closed
Tracked by #194790
ninoslavmiskovic opened this issue Dec 10, 2024 · 2 comments · Fixed by #204744
Closed
Tracked by #194790

[Discover] - Add "Copy" action/button for field values once fields are selected in Discover. #203550

ninoslavmiskovic opened this issue Dec 10, 2024 · 2 comments · Fixed by #204744
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. papercut Small "burr" in the product that we should fix. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@ninoslavmiskovic
Copy link
Contributor

Describe the feature:

Currently, when viewing documents with no fields (summary column) in the Discover table, users can easily copy the value using a button. However, the copy button is removed when specific fields are added to the table. This request is around adding the copy field value CTA directly from the cell in the table, similar to how it works when no fields are displayed.

Additionally, we could consider that the copy value buttons in the field pop-out window be moved to the top, making it quicker to copy values in fields with large amounts of text without needing to scroll.

Recording showing the missing button:

Skaermoptagelse.2024-12-10.kl.13.03.49.mov
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 10, 2024
@ninoslavmiskovic ninoslavmiskovic added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Dec 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 10, 2024
@ninoslavmiskovic ninoslavmiskovic added the papercut Small "burr" in the product that we should fix. label Dec 10, 2024
@ninoslavmiskovic ninoslavmiskovic mentioned this issue Dec 10, 2024
Open
@kertal
Copy link
Member

kertal commented Dec 11, 2024

note that this copy action doesn't need to be added, we would "just" need to configure the UnifiedDataTable to show more visible cell actions:

columns.visibleCellActions

@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. enhancement New value added to drive a business result labels Dec 11, 2024
@jughosta jughosta self-assigned this Dec 18, 2024
@jughosta jughosta mentioned this issue Dec 18, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 19, 2024
@jughosta
[Discover] Make Copy action visible on cell hover (elastic#204744)
339f5c8 
- Closes elastic#203550

## Summary

This PR increases the default visible actions number from 2 to 3 so Copy
action is also included now on cell hover.

Before:
<img width="455" alt="Screenshot 2024-12-18 at 13 29 11"
src="https://github.com/user-attachments/assets/420809f4-1ed3-468a-bf23-326e91c5283d"
/>

After:
<img width="451" alt="Screenshot 2024-12-18 at 13 28 57"
src="https://github.com/user-attachments/assets/59c55abb-5228-44c4-9d00-801975b50563"
/>

(cherry picked from commit ba35b4e)
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
@jughosta @JoseLuisGJ
[Discover] Make Copy action visible on cell hover (elastic#204744)
92c0a7b 
- Closes elastic#203550

## Summary

This PR increases the default visible actions number from 2 to 3 so Copy
action is also included now on cell hover.

Before:
<img width="455" alt="Screenshot 2024-12-18 at 13 29 11"
src="https://github.com/user-attachments/assets/420809f4-1ed3-468a-bf23-326e91c5283d"
/>

After:
<img width="451" alt="Screenshot 2024-12-18 at 13 28 57"
src="https://github.com/user-attachments/assets/59c55abb-5228-44c4-9d00-801975b50563"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. papercut Small "burr" in the product that we should fix. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Make Copy action visible on cell hover jughosta/kibana
4 participants
@kertal @jughosta @elasticmachine @ninoslavmiskovic