Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Stale rule data is displayed in the upgrade flyout #202779

Closed
Tracked by #201502
xcrzx opened this issue Dec 3, 2024 · 3 comments · Fixed by #202969
Closed
Tracked by #201502

[Security Solution] Stale rule data is displayed in the upgrade flyout #202779

xcrzx opened this issue Dec 3, 2024 · 3 comments · Fixed by #202969
Assignees
@xcrzx
Labels
8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0

Comments

@xcrzx
Copy link
Contributor

xcrzx commented Dec 3, 2024

Summary

Stale rule data is displayed in the rule upgrade flyout after a rule has been edited locally.

Steps to Reproduce

  1. Visit the Rule Updates page to ensure the upgrade/_review endpoint data is loaded locally.
  2. Locate any rule with updates and edit it locally (e.g., rename the rule).
  3. Return to the Rule Updates page and open the updated rule.

Expected Result

The rule update flyout reflects the changes introduced locally.

Actual Result

Stale rule data is displayed in the rule update flyout. Any attempt to update the rule results in an error due to a revision mismatch.

Note

This issue likely occurs because the upgrade/_review cache is not invalidated when a rule is edited. We need to ensure that every rule CRUD operation, including bulk operations, performed locally triggers cache invalidation for the review endpoint.
@xcrzx xcrzx added 8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team triage_needed labels Dec 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@xcrzx xcrzx self-assigned this Dec 4, 2024
This was referenced Dec 4, 2024
Open
Merged
xcrzx added a commit that referenced this issue Dec 5, 2024
@xcrzx
[Security Solution] Add rule upgrade review cache invalidation (#202969)
94c5614 
**Resolves: #202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 5, 2024
@xcrzx
[Security Solution] Add rule upgrade review cache invalidation (elast…
58a89c9 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page

(cherry picked from commit 94c5614)
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@xcrzx @SoniaSanzV
[Security Solution] Add rule upgrade review cache invalidation (elast…
e265907 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
@xcrzx @SoniaSanzV
[Security Solution] Add rule upgrade review cache invalidation (elast…
afe40ca 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
@xcrzx @CAWilson94
[Security Solution] Add rule upgrade review cache invalidation (elast…
512eb31 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this issue Dec 10, 2024
@xcrzx @Samiul-TheSoccerFan
[Security Solution] Add rule upgrade review cache invalidation (elast…
fcb798e 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this issue Dec 11, 2024
@xcrzx @mykolaharmash
[Security Solution] Add rule upgrade review cache invalidation (elast…
d8bff40 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@xcrzx @CAWilson94
[Security Solution] Add rule upgrade review cache invalidation (elast…
9dce172 
…ic#202969)

**Resolves: elastic#202779

## Summary

Implemented proper cache invalidation after rule CRUD operations to
prevent displaying stale data in rule upgrade flyouts. See the linked
issue for more details.

### How to Test

1. Ensure rule customization is enabled
2. Navigate to the Rule Updates page 
3. Locate any rule with updates
4. Make changes to the rule:
   - Edit the rule via the Rule Editing page
   - Use bulk actions
   - Delete the rule
5. Return to the Rule Updates page
   - All introduced changes should be reflected:
     - Modifications should be visible
     - If the rule was deleted, it should no longer appear on the page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcrzx xcrzx

Labels
8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Add rule upgrade review cache invalidation xcrzx/kibana
3 participants
@xcrzx @banderror @elasticmachine