Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboards][ES|QL visualization] ES|QL comments in dark mode are difficult to read #202152

Closed
dolivanu opened this issue Nov 28, 2024 · 4 comments · Fixed by #203965
Closed

[Dashboards][ES|QL visualization] ES|QL comments in dark mode are difficult to read #202152

dolivanu opened this issue Nov 28, 2024 · 4 comments · Fixed by #203965
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. papercut Small "burr" in the product that we should fix. Team:ESQL ES|QL related features in Kibana

Comments

@dolivanu
Copy link

In Dashboards, when creating an ES|QL visualization, if you select the dark mode, the comments are shown in dark gray color, being difficult to read with the black baground:

Image

Choosing another color for the comments could improve readability a lot.
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 28, 2024
@jsanz jsanz added the Team:ESQL ES|QL related features in Kibana label Nov 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 29, 2024
@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana enhancement New value added to drive a business result papercut Small "burr" in the product that we should fix. labels Dec 2, 2024
@stratoula
Copy link
Contributor

cc @ryankeairns

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Dec 2, 2024
@ryankeairns ryankeairns mentioned this issue Dec 11, 2024
Merged
@ryankeairns
Copy link
Contributor

Switching from the Disabled text color to Subdued (euiThemeVars.euiTextSubduedColor) resolves the issue in dark mode. We could use subdued for both modes or keep the lighter Disabled color shade in light mode.

@stratoula stratoula mentioned this issue Dec 12, 2024
Merged
@stratoula
Copy link
Contributor

Yes Ryan this looks so much better. I will create a PR to resolve this too. #203965

stratoula added a commit to stratoula/kibana that referenced this issue Dec 12, 2024
@stratoula
[ES|QL] Improves the comments color in dark mode (elastic#203965)
753c6c9 
## Summary

Closes elastic#202152

Fixes the comments color in dark mode

<img width="928" alt="image"
src="https://github.com/user-attachments/assets/7d007cfa-f6d4-45e9-817d-57178c64d0a4"
/>

(cherry picked from commit 6921de3)

# Conflicts:
#	packages/kbn-monaco/src/esql/lib/esql_theme.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. papercut Small "burr" in the product that we should fix. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Improves the comments color in dark mode stratoula/kibana
5 participants
@jsanz @ryankeairns @dolivanu @elasticmachine @stratoula