Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Feature Flag for Enabling/Disabling the Plugin #201705

Closed
3 tasks
opauloh opened this issue Nov 26, 2024 · 1 comment · Fixed by #203844
Closed
3 tasks

Implement Feature Flag for Enabling/Disabling the Plugin #201705

opauloh opened this issue Nov 26, 2024 · 1 comment · Fixed by #203844
Assignees
@albertoblaz
Labels
8.18 candidate Team:Cloud Security Cloud Security team related
Milestone
9.0

Comments

@opauloh
Copy link
Contributor

opauloh commented Nov 26, 2024

Motivation

To control the rollout and enable experimental testing, we need to implement a feature flag that allows enabling or disabling the "Asset Inventory" plugin.

Definition of Done

  • Use the existing xpack.securitySolution.enableExperimental configuration to add a new feature flag.
  • Implement the feature flag xpack.securitySolution.enableExperimental: ['assetInventoryEnabled'].
  • Update any relevant documentation to explain how to enable the feature.

Out of scope

  • Developing any plugin functionality beyond the feature flag control.
  • Handling of feature flag in environments outside of Kibana (e.g., cloud settings).

Related tasks/epics
@opauloh opauloh added this to the 8.18 milestone Nov 26, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 26, 2024
@opauloh opauloh mentioned this issue Nov 26, 2024
Closed
5 tasks
@opauloh opauloh added the Team:Cloud Security Cloud Security team related label Nov 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 26, 2024
@albertoblaz albertoblaz self-assigned this Dec 11, 2024
@albertoblaz albertoblaz mentioned this issue Dec 11, 2024
Merged
6 tasks
@opauloh opauloh modified the milestones: 8.18, 9.0 Dec 19, 2024
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
@albertoblaz @JoseLuisGJ
Implement feature flag to toggle Asset Inventory plugin (elastic#203844)
0a4f362 
## Summary

Closes elastic#201705.

Reuse security_solution's config to control visibility of Asset
Inventory plugin.

### Definition of done

- [x] Use the existing `xpack.securitySolution.enableExperimental`
configuration to add a new feature flag
- Done in
`x-pack/plugins/security_solution/common/experimental_features.ts`
- [x] Implement the feature flag
`xpack.securitySolution.enableExperimental:
['assetInventoryStoreEnabled']`.
- This can only be done locally in `kibana.dev.yml`, but I can add it to
`kibana.yml` instead.
- [x] Update any relevant documentation to explain how to enable the
feature.
  - Updated plugin's `README` file.

### How to test

In your
[kibana.yml](https://github.com/elastic/kibana/blob/main/config/kibana.yml)
file, add the following entry at the bottom:

```
xpack.securitySolution.enableExperimental: ['assetInventoryStoreEnabled']
```

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@albertoblaz albertoblaz mentioned this issue Jan 2, 2025
Merged
1 task
benakansara pushed a commit to benakansara/kibana that referenced this issue Jan 2, 2025
@albertoblaz @benakansara
Implement feature flag to toggle Asset Inventory plugin (elastic#203844)
33a5f0a 
## Summary

Closes elastic#201705.

Reuse security_solution's config to control visibility of Asset
Inventory plugin.

### Definition of done

- [x] Use the existing `xpack.securitySolution.enableExperimental`
configuration to add a new feature flag
- Done in
`x-pack/plugins/security_solution/common/experimental_features.ts`
- [x] Implement the feature flag
`xpack.securitySolution.enableExperimental:
['assetInventoryStoreEnabled']`.
- This can only be done locally in `kibana.dev.yml`, but I can add it to
`kibana.yml` instead.
- [x] Update any relevant documentation to explain how to enable the
feature.
  - Updated plugin's `README` file.

### How to test

In your
[kibana.yml](https://github.com/elastic/kibana/blob/main/config/kibana.yml)
file, add the following entry at the bottom:

```
xpack.securitySolution.enableExperimental: ['assetInventoryStoreEnabled']
```

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
albertoblaz added a commit that referenced this issue Jan 2, 2025
@albertoblaz
Rename AssetInventory feature flag (#205374)
5b74e12 
## Summary

Renames `assetInventoryStoreEnabled` -> `assetInventoryUXEnabled`

Follow-up of this PR:
- #201705

### Motivation

Deviate from `assetInventoryStoreEnabled` which is also used for backend
changes. This gives us more fine-grained control about changes and the
new `assetInventoryUXEnabled` will only be responsible of showing/hiding
the interface.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Risks

No risk whatsoever
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 2, 2025
@albertoblaz @viduni94
Rename AssetInventory feature flag (elastic#205374)
367ff81 
## Summary

Renames `assetInventoryStoreEnabled` -> `assetInventoryUXEnabled`

Follow-up of this PR:
- elastic#201705

### Motivation

Deviate from `assetInventoryStoreEnabled` which is also used for backend
changes. This gives us more fine-grained control about changes and the
new `assetInventoryUXEnabled` will only be responsible of showing/hiding
the interface.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Risks

No risk whatsoever
cqliu1 pushed a commit to cqliu1/kibana that referenced this issue Jan 2, 2025
@albertoblaz @cqliu1
Rename AssetInventory feature flag (elastic#205374)
f6a077c 
## Summary

Renames `assetInventoryStoreEnabled` -> `assetInventoryUXEnabled`

Follow-up of this PR:
- elastic#201705

### Motivation

Deviate from `assetInventoryStoreEnabled` which is also used for backend
changes. This gives us more fine-grained control about changes and the
new `assetInventoryUXEnabled` will only be responsible of showing/hiding
the interface.

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Risks

No risk whatsoever
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertoblaz albertoblaz

Labels
8.18 candidate Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

Implement feature flag to toggle Asset Inventory plugin albertoblaz/kibana
3 participants
@albertoblaz @elasticmachine @opauloh