-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs] Deprecate legacy/unused advanced settings #200900
Labels
Team:obs-ux-logs
Observability Logs User Experience Team
Comments
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
tonyghiani
added a commit
that referenced
this issue
Dec 5, 2024
## 📓 Summary Closes #200900 As part of the readiness requirements to upgrade Kibana to v9.0.0, this work deprecates some advanced settings that will be removed. <img width="2568" alt="Screenshot 2024-11-21 at 11 15 25" src="https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2"> Co-authored-by: Marco Antonio Ghiani <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 5, 2024
## 📓 Summary Closes elastic#200900 As part of the readiness requirements to upgrade Kibana to v9.0.0, this work deprecates some advanced settings that will be removed. <img width="2568" alt="Screenshot 2024-11-21 at 11 15 25" src="https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2"> Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit f30f0a8)
kibanamachine
added a commit
that referenced
this issue
Dec 5, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Logs] Deprecate advanced settings for v9.0.0 (#201102)](#201102) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T10:49:52Z","message":"[Logs] Deprecate advanced settings for v9.0.0 (#201102)\n\n## 📓 Summary\r\n\r\nCloses #200900 \r\n\r\nAs part of the readiness requirements to upgrade Kibana to v9.0.0, this\r\nwork deprecates some advanced settings that will be removed.\r\n\r\n<img width=\"2568\" alt=\"Screenshot 2024-11-21 at 11 15 25\"\r\nsrc=\"https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2\">\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"f30f0a8f33cca137f465bf6abd4f5567a9d866b8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Logs] Deprecate advanced settings for v9.0.0","number":201102,"url":"https://github.com/elastic/kibana/pull/201102","mergeCommit":{"message":"[Logs] Deprecate advanced settings for v9.0.0 (#201102)\n\n## 📓 Summary\r\n\r\nCloses #200900 \r\n\r\nAs part of the readiness requirements to upgrade Kibana to v9.0.0, this\r\nwork deprecates some advanced settings that will be removed.\r\n\r\n<img width=\"2568\" alt=\"Screenshot 2024-11-21 at 11 15 25\"\r\nsrc=\"https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2\">\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"f30f0a8f33cca137f465bf6abd4f5567a9d866b8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201102","number":201102,"mergeCommit":{"message":"[Logs] Deprecate advanced settings for v9.0.0 (#201102)\n\n## 📓 Summary\r\n\r\nCloses #200900 \r\n\r\nAs part of the readiness requirements to upgrade Kibana to v9.0.0, this\r\nwork deprecates some advanced settings that will be removed.\r\n\r\n<img width=\"2568\" alt=\"Screenshot 2024-11-21 at 11 15 25\"\r\nsrc=\"https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2\">\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"f30f0a8f33cca137f465bf6abd4f5567a9d866b8"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this issue
Dec 9, 2024
## 📓 Summary Closes elastic#200900 As part of the readiness requirements to upgrade Kibana to v9.0.0, this work deprecates some advanced settings that will be removed. <img width="2568" alt="Screenshot 2024-11-21 at 11 15 25" src="https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2"> Co-authored-by: Marco Antonio Ghiani <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this issue
Dec 9, 2024
## 📓 Summary Closes elastic#200900 As part of the readiness requirements to upgrade Kibana to v9.0.0, this work deprecates some advanced settings that will be removed. <img width="2568" alt="Screenshot 2024-11-21 at 11 15 25" src="https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2"> Co-authored-by: Marco Antonio Ghiani <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 9, 2024
## 📓 Summary Closes elastic#200900 As part of the readiness requirements to upgrade Kibana to v9.0.0, this work deprecates some advanced settings that will be removed. <img width="2568" alt="Screenshot 2024-11-21 at 11 15 25" src="https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2"> Co-authored-by: Marco Antonio Ghiani <[email protected]>
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this issue
Dec 10, 2024
## 📓 Summary Closes elastic#200900 As part of the readiness requirements to upgrade Kibana to v9.0.0, this work deprecates some advanced settings that will be removed. <img width="2568" alt="Screenshot 2024-11-21 at 11 15 25" src="https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2"> Co-authored-by: Marco Antonio Ghiani <[email protected]>
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this issue
Dec 11, 2024
## 📓 Summary Closes elastic#200900 As part of the readiness requirements to upgrade Kibana to v9.0.0, this work deprecates some advanced settings that will be removed. <img width="2568" alt="Screenshot 2024-11-21 at 11 15 25" src="https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2"> Co-authored-by: Marco Antonio Ghiani <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 12, 2024
## 📓 Summary Closes elastic#200900 As part of the readiness requirements to upgrade Kibana to v9.0.0, this work deprecates some advanced settings that will be removed. <img width="2568" alt="Screenshot 2024-11-21 at 11 15 25" src="https://github.com/user-attachments/assets/81b9a8dc-6ad2-4646-9516-ed9a90d7bef2"> Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
📓 Summary
Deprecated advanced settings (under Stack Management > Advanced Settings) should be surfaced in UA using the feature deprecation mechanism. If any user action is needed it should be clearly explained as steps. If no specific user action is required you can skip registering feature deprecation.
Additionally, deprecation status must be reflected in the UI, for example:
Add a release note: please see this example of a release note so that this change can be linked to/surfaced in our docs
✔ Acceptance criteria
observability:enableLogsStream
)This advanced setting is used in latest 8.x versions to re-enable the deprecated Logs Stream app. It is already marked as deprecated as part of the Logs Stream feature deprecation work. No explicit upgrade action is required.
observability:logsExplorer:allowedDataViews
)This advanced setting was created to differentiate logs data views from any other source type. As we move towards One Discover and the Observability Logs Explorer app will be removed, this advanced setting should also be deprecated. No explicit upgrade action is required since the equivalent behaviour is already implemented in One Discover through the contextual resolution.
The text was updated successfully, but these errors were encountered: