Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] rewrite BucketNestingEditor tests to react testing library #199839

Closed
mbondyra opened this issue Nov 12, 2024 · 1 comment · Fixed by #199888
Closed

[Lens] rewrite BucketNestingEditor tests to react testing library #199839

mbondyra opened this issue Nov 12, 2024 · 1 comment · Fixed by #199888
Labels
Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort refactoring Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

Describe the feature:

As an ongoing effort in our team, we want to progressively remove enzyme and replace it with react testing library in our part of repository.
Let's remove it from https://github.com/elastic/kibana/blob/main/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/bucket_nesting_editor.test.tsx file and replace it with react testing library.

Example of PRs where we already did it for other files:

#187637
#173075
@mbondyra mbondyra added Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort refactoring Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kyracho kyracho mentioned this issue Nov 12, 2024
Merged
@mariairiartef mariairiartef removed their assignment Nov 13, 2024
jesuswr pushed a commit to jesuswr/kibana that referenced this issue Nov 18, 2024
@kyracho @mbondyra @jesuswr
[Lens] rewrite BucketNestingEditor tests to use react testing library (…
4fd0b10 
…elastic#199888)

## Summary

Hi! This PR rewrites the `BucketNestingEditor` tests to use the react
testing library.

Fixes elastic#199839 

<img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM"
src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1">

### Checklist

- [n/a] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Marta Bondyra <[email protected]>
mbondyra pushed a commit to mbondyra/kibana that referenced this issue Nov 25, 2024
@kyracho
[Lens] rewrite BucketNestingEditor tests to use react testing library (…
42f5cdf 
…elastic#199888)

## Summary

Hi! This PR rewrites the `BucketNestingEditor` tests to use the react
testing library.

Fixes elastic#199839

<img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM"
src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1">

### Checklist

- [n/a] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Marta Bondyra <[email protected]>
(cherry picked from commit eddfe5b)
mbondyra pushed a commit to mbondyra/kibana that referenced this issue Nov 25, 2024
@kyracho
[Lens] rewrite BucketNestingEditor tests to use react testing library (…
e28ab99 
…elastic#199888)

## Summary

Hi! This PR rewrites the `BucketNestingEditor` tests to use the react
testing library.

Fixes elastic#199839

<img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM"
src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1">

### Checklist

- [n/a] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Marta Bondyra <[email protected]>
(cherry picked from commit eddfe5b)
mbondyra added a commit that referenced this issue Nov 26, 2024
@mbondyra @kyracho
[8.x] [Lens] rewrite BucketNestingEditor tests to use react testing l…
4a48ec8 
…ibrary (#199888) (#201529)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] rewrite BucketNestingEditor tests to use react testing library
(#199888)](#199888)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kyra
Cho","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T16:46:33Z","message":"[Lens]
rewrite BucketNestingEditor tests to use react testing library
(#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the
`BucketNestingEditor` tests to use the react\r\ntesting
library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\"
alt=\"Screenshot 2024-11-12 at 3 35
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n###
Checklist\r\n\r\n- [n/a] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport
missing","💝community","v9.0.0","backport:version"],"number":199888,"url":"https://github.com/elastic/kibana/pull/199888","mergeCommit":{"message":"[Lens]
rewrite BucketNestingEditor tests to use react testing library
(#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the
`BucketNestingEditor` tests to use the react\r\ntesting
library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\"
alt=\"Screenshot 2024-11-12 at 3 35
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n###
Checklist\r\n\r\n- [n/a] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199888","number":199888,"mergeCommit":{"message":"[Lens]
rewrite BucketNestingEditor tests to use react testing library
(#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the
`BucketNestingEditor` tests to use the react\r\ntesting
library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\"
alt=\"Screenshot 2024-11-12 at 3 35
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n###
Checklist\r\n\r\n- [n/a] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb"}}]}]
BACKPORT-->

Co-authored-by: Kyra Cho <[email protected]>
mbondyra added a commit that referenced this issue Nov 26, 2024
@mbondyra @kyracho
[8.17] [Lens] rewrite BucketNestingEditor tests to use react testing …
1651d1b 
…library (#199888) (#201530)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Lens] rewrite BucketNestingEditor tests to use react testing library
(#199888)](#199888)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kyra
Cho","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T16:46:33Z","message":"[Lens]
rewrite BucketNestingEditor tests to use react testing library
(#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the
`BucketNestingEditor` tests to use the react\r\ntesting
library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\"
alt=\"Screenshot 2024-11-12 at 3 35
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n###
Checklist\r\n\r\n- [n/a] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport
missing","💝community","v9.0.0","backport:version"],"number":199888,"url":"https://github.com/elastic/kibana/pull/199888","mergeCommit":{"message":"[Lens]
rewrite BucketNestingEditor tests to use react testing library
(#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the
`BucketNestingEditor` tests to use the react\r\ntesting
library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\"
alt=\"Screenshot 2024-11-12 at 3 35
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n###
Checklist\r\n\r\n- [n/a] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199888","number":199888,"mergeCommit":{"message":"[Lens]
rewrite BucketNestingEditor tests to use react testing library
(#199888)\n\n## Summary\r\n\r\nHi! This PR rewrites the
`BucketNestingEditor` tests to use the react\r\ntesting
library.\r\n\r\nFixes #199839 \r\n\r\n<img width=\"1063\"
alt=\"Screenshot 2024-11-12 at 3 35
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1\">\r\n\r\n###
Checklist\r\n\r\n- [n/a] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<[email protected]>","sha":"eddfe5b8a73ac636d5e75606280bd771a01b1adb"}}]}]
BACKPORT-->

Co-authored-by: Kyra Cho <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@kyracho @mbondyra @CAWilson94
[Lens] rewrite BucketNestingEditor tests to use react testing library (…
4b6978f 
…elastic#199888)

## Summary

Hi! This PR rewrites the `BucketNestingEditor` tests to use the react
testing library.

Fixes elastic#199839 

<img width="1063" alt="Screenshot 2024-11-12 at 3 35 06 PM"
src="https://github.com/user-attachments/assets/95036fe0-46e8-4bf2-9d77-31d225d38ed1">

### Checklist

- [n/a] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort refactoring Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] rewrite BucketNestingEditor tests to use react testing library kyracho/kibana
3 participants
@mbondyra @elasticmachine @mariairiartef