-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIbana Rules] APM threshold chart preview breaks KQL filter UI #199273
Comments
Maybe introduced/related to #164540 ? |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart (cherry picked from commit f1109cf)
…is invalid (#203096) (#203134) # Backport This will backport the following commits from `main` to `8.x`: - [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)](#203096) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T16:07:58Z","message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management"],"title":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid","number":203096,"url":"https://github.com/elastic/kibana/pull/203096","mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203096","number":203096,"mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <[email protected]>
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart
@jasonrhodes To get a second opinion, shall we backport this fix to |
Looks like we can get it in for 8.16.2 if we are quick so that seems like a good idea to me if it's safe to do that with this fix (I've not looked at the specific code of the fix) |
Seems safe to me, @fkanout do you agree? |
@maryam-saeidi, yes. |
Backported #203096 (comment) |
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart (cherry picked from commit f1109cf)
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart (cherry picked from commit f1109cf)
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart (cherry picked from commit f1109cf)
… is invalid (#203096) (#203466) # Backport This will backport the following commits from `main` to `8.15`: - [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)](#203096) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T16:07:58Z","message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.18.0"],"title":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid","number":203096,"url":"https://github.com/elastic/kibana/pull/203096","mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203096","number":203096,"mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203134","number":203134,"state":"MERGED","mergeCommit":{"sha":"a70bdf01cd8208c0f2358a98f5fcc5d10ac0a7d6","message":"[8.x] [OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096) (#203134)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is\ninvalid (#203096)](https://github.com/elastic/kibana/pull/203096)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Faisal\nKanout\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-05T16:07:58Z\",\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"Team:obs-ux-management\"],\"title\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is\ninvalid\",\"number\":203096,\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"number\":203096,\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}}]}] BACKPORT-->\n\nCo-authored-by: Faisal Kanout <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <[email protected]>
… is invalid (#203096) (#203468) # Backport This will backport the following commits from `main` to `8.17`: - [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)](#203096) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T16:07:58Z","message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.18.0"],"title":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid","number":203096,"url":"https://github.com/elastic/kibana/pull/203096","mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203096","number":203096,"mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203134","number":203134,"state":"MERGED","mergeCommit":{"sha":"a70bdf01cd8208c0f2358a98f5fcc5d10ac0a7d6","message":"[8.x] [OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096) (#203134)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is\ninvalid (#203096)](https://github.com/elastic/kibana/pull/203096)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Faisal\nKanout\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-05T16:07:58Z\",\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"Team:obs-ux-management\"],\"title\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is\ninvalid\",\"number\":203096,\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"number\":203096,\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}}]}] BACKPORT-->\n\nCo-authored-by: Faisal Kanout <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <[email protected]>
… is invalid (#203096) (#203467) # Backport This will backport the following commits from `main` to `8.16`: - [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)](#203096) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T16:07:58Z","message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-minor","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.18.0"],"title":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid","number":203096,"url":"https://github.com/elastic/kibana/pull/203096","mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203096","number":203096,"mergeCommit":{"message":"[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096)\n\n## Summary\r\n\r\nIt fixes #199273 by validating\r\nthe query before passing it to the preview chart","sha":"f1109cfccedfd386263a00207df81c766cfaf6e4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203134","number":203134,"state":"MERGED","mergeCommit":{"sha":"a70bdf01cd8208c0f2358a98f5fcc5d10ac0a7d6","message":"[8.x] [OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is invalid (#203096) (#203134)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[OBX-UX-MGMT][ALERTING] Fix APM rule error msg when KQL filter is\ninvalid (#203096)](https://github.com/elastic/kibana/pull/203096)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Faisal\nKanout\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-05T16:07:58Z\",\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-infra_services\",\"Team:obs-ux-management\"],\"title\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is\ninvalid\",\"number\":203096,\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203096\",\"number\":203096,\"mergeCommit\":{\"message\":\"[OBX-UX-MGMT][ALERTING]\nFix APM rule error msg when KQL filter is invalid (#203096)\\n\\n##\nSummary\\r\\n\\r\\nIt fixes https://github.com/elastic/kibana/issues/199273\nby validating\\r\\nthe query before passing it to the preview\nchart\",\"sha\":\"f1109cfccedfd386263a00207df81c766cfaf6e4\"}}]}] BACKPORT-->\n\nCo-authored-by: Faisal Kanout <[email protected]>"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <[email protected]>
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart
…alid (elastic#203096) ## Summary It fixes elastic#199273 by validating the query before passing it to the preview chart
Kibana version:
8.15.3
Elasticsearch version:
8.15.3
Server OS version:
n/a
Browser version:
Firefox 132.0..1
Browser OS version:
MacOS 14.7.1
Original install method (e.g. download page, yum, from source, etc.):
ECK
Describe the bug:
APM and User experience rules that support enabling KQL filter (Error count threshold, Failed transaction rate threshold, Latency threshold) are all subject to the same bug due to live reloading of the chart preview when KQL filter is enabled
Steps to reproduce:
Expected behavior:
No annoying popup error should appear, live chart should be updated when a syntactically valid KQL filter is entered
Screenshots (if relevant):
Errors in browser console (if relevant):
Provide logs and/or server output (if relevant):
Any additional context:
The error seems to be related to the update of the chart preview as the user type.
The content of the Query KQL Filter textbox appears to be used to feed a
SearchConfiguration
parameter sent to the/internal/apm/rule_types/error_count/chart_preview
endpoint.When the current KQL filter textbox contains a non syntactically valid filter (like
service.name:
), then an annoying error is displayedThe text was updated successfully, but these errors were encountered: