Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Migrate /test/apm_api_integration/tests/errors/ to be deployment-agnostic API tests #198971

Closed
rmyz opened this issue Nov 5, 2024 · 2 comments · Fixed by #199655
Closed
Assignees
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@rmyz
Copy link
Contributor

rmyz commented Nov 5, 2024

No description provided.

@rmyz rmyz added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture labels Nov 5, 2024
@jennypavlova jennypavlova self-assigned this Nov 8, 2024
@kpatticha
Copy link
Contributor

@jennypavlova FYI you might see the same error regarding the grouping name.

Once the #199021 is merged it will solve the issue but you might need to update some of the errors

@jennypavlova
Copy link
Member

@kpatticha Thank you! I will take a look - so far I have some failing tests that I need to investigate but I think it was not creating the synthtrace data as the result was undefined instead of the expected one. So I will keep this one in mind and pull when it's merged :)

jennypavlova added a commit that referenced this issue Nov 14, 2024
…t agnostic api tests (#199655)

Closes #198971 
Part of #193245

## Summary

This PR migrates test apm-api-integration/tests/errors to be deployment
agnostic api tests

## Testing

Serverless:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```
Stateful:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 14, 2024
…t agnostic api tests (elastic#199655)

Closes elastic#198971
Part of elastic#193245

## Summary

This PR migrates test apm-api-integration/tests/errors to be deployment
agnostic api tests

## Testing

Serverless:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```
Stateful:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

(cherry picked from commit 7921f56)
kibanamachine added a commit that referenced this issue Nov 14, 2024
… to be deployment agnostic api tests (#199655) (#200130)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Migrate test `apm-api-integration/tests/errors` to be
deployment agnostic api tests
(#199655)](#199655)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-14T09:39:46Z","message":"[APM]
Migrate test `apm-api-integration/tests/errors` to be deployment
agnostic api tests (#199655)\n\nCloses #198971 \r\nPart of
#193245\r\n\r\n## Summary\r\n\r\nThis PR migrates test
apm-api-integration/tests/errors to be deployment\r\nagnostic api
tests\r\n\r\n## Testing\r\n\r\nServerless:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\nStateful:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```","sha":"7921f5618d6af8e959ed4c52a91a026c672955ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM]
Migrate test `apm-api-integration/tests/errors` to be deployment
agnostic api
tests","number":199655,"url":"https://github.com/elastic/kibana/pull/199655","mergeCommit":{"message":"[APM]
Migrate test `apm-api-integration/tests/errors` to be deployment
agnostic api tests (#199655)\n\nCloses #198971 \r\nPart of
#193245\r\n\r\n## Summary\r\n\r\nThis PR migrates test
apm-api-integration/tests/errors to be deployment\r\nagnostic api
tests\r\n\r\n## Testing\r\n\r\nServerless:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\nStateful:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```","sha":"7921f5618d6af8e959ed4c52a91a026c672955ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199655","number":199655,"mergeCommit":{"message":"[APM]
Migrate test `apm-api-integration/tests/errors` to be deployment
agnostic api tests (#199655)\n\nCloses #198971 \r\nPart of
#193245\r\n\r\n## Summary\r\n\r\nThis PR migrates test
apm-api-integration/tests/errors to be deployment\r\nagnostic api
tests\r\n\r\n## Testing\r\n\r\nServerless:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"APM\"\r\n```\r\nStateful:\r\n\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"APM\"\r\n```","sha":"7921f5618d6af8e959ed4c52a91a026c672955ea"}}]}]
BACKPORT-->

Co-authored-by: jennypavlova <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
…t agnostic api tests (elastic#199655)

Closes elastic#198971 
Part of elastic#193245

## Summary

This PR migrates test apm-api-integration/tests/errors to be deployment
agnostic api tests

## Testing

Serverless:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```
Stateful:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
…t agnostic api tests (elastic#199655)

Closes elastic#198971 
Part of elastic#193245

## Summary

This PR migrates test apm-api-integration/tests/errors to be deployment
agnostic api tests

## Testing

Serverless:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```
Stateful:

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
3 participants