Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Timeline new actions buttons tour appears misaligned #197295

Closed
vgomez-el opened this issue Oct 22, 2024 · 6 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Milestone

Comments

@vgomez-el
Copy link
Contributor

vgomez-el commented Oct 22, 2024

Describe the bug:
The tour for new Action buttons on Timelines appears misaligned when creating a new timeline.

Kibana/Elasticsearch Stack version:
8.16 BC1

Browser and Browser OS versions:
Chrome

Original install method (e.g. download page, yum, from source, etc.):
Cloud deployment

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Timelines

Steps to reproduce:
Preconditions: Bug has been found in a fresh Kibana instance

  1. Navigate to Security Alerts section
  2. Click on Untitled timeline on the bottom of the page to create a new Timeline
  3. Observe the tour tooltip location

Current behavior:
The tour tooltip may appear aligned the first try, but when closing and opening again the timeline, the tooltip is misaligned

Expected behavior:
Tooltip should be aligned every time the user opens or closes Timelines until the user skips or finishes the tour
Screenshots (if relevant):
https://github.com/user-attachments/assets/4d7e563b-0039-4f65-8bac-e77ec1df3d7e
Image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context (logs, chat logs, magical formulas, etc.):

@vgomez-el vgomez-el added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team triage_needed labels Oct 22, 2024
@vgomez-el vgomez-el added this to the 8.16 milestone Oct 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

logeekal added a commit that referenced this issue Oct 25, 2024
…97385)

## Summary

Handles #197295

This PR removes the obselete timeline tour which was introduced in
`8.12` and may not be relevant now in `8.16`.

From the perspective of users directly to `8.16` from `8.11`. I guess it
might be okay for users to expect considerable changes that may have
happened between `8.11` and `8.16` and a tour might not be necessary 🤷
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 25, 2024
…astic#197385)

## Summary

Handles elastic#197295

This PR removes the obselete timeline tour which was introduced in
`8.12` and may not be relevant now in `8.16`.

From the perspective of users directly to `8.16` from `8.11`. I guess it
might be okay for users to expect considerable changes that may have
happened between `8.11` and `8.16` and a tour might not be necessary 🤷

(cherry picked from commit 663a339)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 25, 2024
…astic#197385)

## Summary

Handles elastic#197295

This PR removes the obselete timeline tour which was introduced in
`8.12` and may not be relevant now in `8.16`.

From the perspective of users directly to `8.16` from `8.11`. I guess it
might be okay for users to expect considerable changes that may have
happened between `8.11` and `8.16` and a tour might not be necessary 🤷

(cherry picked from commit 663a339)
@PhilippeOberti
Copy link
Contributor

@logeekal I believe this ticket can be closed correct?

@logeekal
Copy link
Contributor

logeekal commented Nov 4, 2024

@PhilippeOberti , marked this ticket as fixed since we have removed the tour in 8.16, 8.x.

@vgomez-el , could you please validate this in an incognito window in current BC.

@vgomez-el
Copy link
Contributor Author

Hey @logeekal ,

I have re-tested it under incognito mode in 8.16 BC3 and I can say that the bug is fixed since the tour guide is not being displayed.

Image

Thanks for working on it!

@michaelolo24 michaelolo24 added the QA:Validated Issue has been validated by QA label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

No branches or pull requests

5 participants