Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddables Rebuild] Migrate Dashboard embeddable to plain javascript object #197281

Closed
Tracked by #167429
nreese opened this issue Oct 22, 2024 · 0 comments · Fixed by #194892
Closed
Tracked by #167429

[Embeddables Rebuild] Migrate Dashboard embeddable to plain javascript object #197281

nreese opened this issue Oct 22, 2024 · 0 comments · Fixed by #194892
Assignees
Labels
Feature:Embeddables Relating to the Embeddable system project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Oct 22, 2024

No description provided.

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas project:embeddableRebuild labels Oct 22, 2024
@nreese nreese self-assigned this Oct 22, 2024
@nreese nreese added the Feature:Embeddables Relating to the Embeddable system label Oct 22, 2024
nreese added a commit that referenced this issue Dec 10, 2024
Closes #197281

PR replaces `DashboardContainer`, which implements legacy Container and
Embeddable interfaces, with plain old javascript object implementation
returned from `getDashboardApi`.

The following are out of scope for this PR and will be accomplished at a
later time:
1) re-factoring dashboard folder structure
2) removing all uses of Embeddable and EmbeddableInput types
3) removing legacy types like DashboardContainerInput

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Hannah Mudge <[email protected]>
Co-authored-by: Devon Thomson <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 10, 2024
Closes elastic#197281

PR replaces `DashboardContainer`, which implements legacy Container and
Embeddable interfaces, with plain old javascript object implementation
returned from `getDashboardApi`.

The following are out of scope for this PR and will be accomplished at a
later time:
1) re-factoring dashboard folder structure
2) removing all uses of Embeddable and EmbeddableInput types
3) removing legacy types like DashboardContainerInput

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Hannah Mudge <[email protected]>
Co-authored-by: Devon Thomson <[email protected]>
(cherry picked from commit 101e797)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
Closes elastic#197281

PR replaces `DashboardContainer`, which implements legacy Container and
Embeddable interfaces, with plain old javascript object implementation
returned from `getDashboardApi`.

The following are out of scope for this PR and will be accomplished at a
later time:
1) re-factoring dashboard folder structure
2) removing all uses of Embeddable and EmbeddableInput types
3) removing legacy types like DashboardContainerInput

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Hannah Mudge <[email protected]>
Co-authored-by: Devon Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embeddables Relating to the Embeddable system project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant