Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability Onboarding] Change test-subj id on the feedback buttons #196297

Closed
mykolaharmash opened this issue Oct 15, 2024 · 2 comments · Fixed by #197311
Closed

[Observability Onboarding] Change test-subj id on the feedback buttons #196297

mykolaharmash opened this issue Oct 15, 2024 · 2 comments · Fixed by #197311
Labels
bug Fixes for quality problems that affect the customer experience Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@mykolaharmash
Copy link
Contributor

mykolaharmash commented Oct 15, 2024 •
edited
Loading

Right now the buttons use 'observabilityAiAssistantFeedbackButtonsPositiveButton' and observabilityAiAssistantFeedbackButtonsNegativeButton, we need to change it to be onboarding specific.
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 15, 2024
@mykolaharmash mykolaharmash added the Team:obs-ux-logs Observability Logs User Experience Team label Oct 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 15, 2024
@gbamparop gbamparop added bug Fixes for quality problems that affect the customer experience technical debt Improvement of the software architecture and operational architecture Feature: Observability Onboarding labels Oct 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-onboarding-team (Feature: Observability Onboarding)

@gbamparop gbamparop mentioned this issue Oct 22, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 25, 2024
@gbamparop
Update the test subjects of the feedback buttons (elastic#197311)
c9146e4 
Update the test subjects of the feedback buttons.

Closes elastic#196297

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 188beda)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 25, 2024
@gbamparop
Update the test subjects of the feedback buttons (elastic#197311)
ecb3cef 
Update the test subjects of the feedback buttons.

Closes elastic#196297

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 188beda)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature: Observability Onboarding Team:obs-ux-logs Observability Logs User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the test subjects of the feedback buttons gbamparop/kibana
3 participants
@mykolaharmash @gbamparop @elasticmachine