Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Synthetics API integration tests to deployment agnostic solution #196229

Open
jasonrhodes opened this issue Oct 15, 2024 · 1 comment
Open

Migrate Synthetics API integration tests to deployment agnostic solution #196229

jasonrhodes opened this issue Oct 15, 2024 · 1 comment
Assignees
@dominiqueclarke
Labels
Team:obs-ux-management Observability Management User Experience Team

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Oct 15, 2024 •
edited by dominiqueclarke
Loading

🍒 Summary

After #183113 is merged, we have a way to write deployment agnostic tests for SLO and o11y alerting features.

Test Type ESS Serverless Notes
Synthetics CRUD Synthetics ✅ ✅ Extensive ESS tests at x-pack/test/api_integration/apis/synthetics/config.ts. Limited serverless tests at x-pack/test_serverless/api_integration/test_suites/observability/synthetics/index.ts
Synthetics alerting Alerting ✅ ❌ ESS: x-pack/test/alerting_api_integration/observability/metric_threshold_rule.ts

The above table is a compilation of our current API integration tests for the slo and alerting features. Some tests are duplicated in both environments, others are implemented either in serverless or ESS environments and there are also some tests (SLO) where the implementation is not the same in both environments and should be unified.
@jasonrhodes jasonrhodes mentioned this issue Oct 15, 2024
Open
@jasonrhodes jasonrhodes added the Team:obs-ux-management Observability Management User Experience Team label Oct 15, 2024
@dominiqueclarke dominiqueclarke self-assigned this Nov 4, 2024
@maryam-saeidi maryam-saeidi mentioned this issue Nov 5, 2024
Closed
@paulb-elastic paulb-elastic changed the title Migrate Synthetics API integration tests to deployment agnostic solution [Meta] Migrate Synthetics API integration tests to deployment agnostic solution Nov 6, 2024
@paulb-elastic paulb-elastic changed the title [Meta] Migrate Synthetics API integration tests to deployment agnostic solution Migrate Synthetics API integration tests to deployment agnostic solution Nov 6, 2024
@dominiqueclarke dominiqueclarke mentioned this issue Nov 18, 2024
Merged
dominiqueclarke added a commit that referenced this issue Dec 12, 2024
@dominiqueclarke @kibanamachine @shahzad31
[Synthetics] migrate first set of tests (#198950)
b74b935 
## Summary

Relates to #196229 

Migrates Synthetics tests to deployment agnostic

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this issue Dec 12, 2024
@dominiqueclarke
[Synthetics] migrate first set of tests (elastic#198950)
5d27c61 
## Summary

Relates to elastic#196229

Migrates Synthetics tests to deployment agnostic

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Shahzad <[email protected]>
(cherry picked from commit b74b935)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/test/api_integration/deployment_agnostic/default_configs/serverless.config.base.ts
dominiqueclarke added a commit that referenced this issue Dec 13, 2024
@dominiqueclarke
[8.x] [Synthetics] migrate first set of tests (#198950) (#204083)
16f7615 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] migrate first set of tests
(#198950)](#198950)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T14:41:03Z","message":"[Synthetics]
migrate first set of tests (#198950)\n\n## Summary\r\n\r\nRelates to
#196229 \r\n\r\nMigrates Synthetics tests to deployment
agnostic\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Shahzad
<[email protected]>","sha":"b74b93593cecec34e2745c30811c6929bf8a72c7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"number":198950,"url":"https://github.com/elastic/kibana/pull/198950","mergeCommit":{"message":"[Synthetics]
migrate first set of tests (#198950)\n\n## Summary\r\n\r\nRelates to
#196229 \r\n\r\nMigrates Synthetics tests to deployment
agnostic\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Shahzad
<[email protected]>","sha":"b74b93593cecec34e2745c30811c6929bf8a72c7"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198950","number":198950,"mergeCommit":{"message":"[Synthetics]
migrate first set of tests (#198950)\n\n## Summary\r\n\r\nRelates to
#196229 \r\n\r\nMigrates Synthetics tests to deployment
agnostic\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Shahzad
<[email protected]>","sha":"b74b93593cecec34e2745c30811c6929bf8a72c7"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Dec 16, 2024 •
edited
Loading

handled the first section, with one caveat

  1. Params tests are currently skipped in deployment agnostic (still running in our stateful only tests) due to [Synthetics] [Serverless] Params not able to be viewed by any user role in serverless #200479.

This leaves the status as follows

Test Type ESS Serverless Notes
Synthetics CRUD Synthetics ✅ ✅ Extensive ESS tests at x-pack/test/api_integration/apis/synthetics/config.ts. Limited serverless tests at x-pack/test_serverless/api_integration/test_suites/observability/synthetics/index.ts
Synthetics alerting Alerting ✅ ❌ ESS: x-pack/test/alerting_api_integration/observability/metric_threshold_rule.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominiqueclarke dominiqueclarke

Labels
Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonrhodes @dominiqueclarke