Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Unskip tests for preventing non-customizable fields from updating for Prebuilt rule types #195921

Open
banderror opened this issue Oct 11, 2024 · 4 comments
Open

[Security Solution] Unskip tests for preventing non-customizable fields from updating for Prebuilt rule types #195921

banderror opened this issue Oct 11, 2024 · 4 comments
Assignees
@jpdjere @dplumlee
Labels
8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@banderror
Copy link
Contributor

banderror commented Oct 11, 2024 •
edited
Loading

Related to: #195318, #195926

Summary

Tests added in #195318 failed in the periodic pipeline (build) and were skipped in #195926.

That failure happened in installPrebuiltRules -> refreshSavedObjectIndices.

Saved objects refresh doesn't work in serverless pipelines, such as the 2nd quality gate and the periodic pipeline. We added it in this PR to reduce flakiness. However, we might not need it anymore since @maximpn added a refresh: 'wait_for' to the Fleet's package installation code in this PR.

Let's try to unskip these tests to keep them enabled in the 2nd quality gate.
@banderror banderror added Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area skipped-test Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team labels Oct 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror mentioned this issue Oct 11, 2024
Merged
banderror added a commit that referenced this issue Oct 11, 2024
@banderror
[Security Solution] Skip recently added tests for updating restricted…
d57bc9a 
… fields in prebuilt rules (#195926)

## Summary

The new tests added yesterday in
#195318 have failed in the
periodic pipeline
([build](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/1408#019279c2-233d-405e-8758-7864b84d0524)).

Skipping for now in MKI pipelines (periodic pipeline and the 2nd quality
gate), otherwise it will block the next Serverless release.

Ticket for unskipping: #195921
@dplumlee
Copy link
Contributor

dplumlee commented Nov 1, 2024

Note: when this PR gets merged, we won't need to unskip the bulk route tests in 9.0 as the files will be skipped permanently or deleted. We will still have to unskip and backport to 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpdjere jpdjere

@dplumlee dplumlee

Labels
8.18 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpdjere @banderror @elasticmachine @dplumlee