[Index Management] Flashing error banner when navigating away from Logistics step in Index Template form #194751
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Index Management
Index and index templates UI
good first issue
low hanging fruit
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Comments
ElenaStoeva
added
bug
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
ElenaStoeva
changed the title
|
I would love to work on this 🙌 |
|
hello @alisonelizabeth, I'd like to work on this issue. |
|
Hi @Naman-B-Parlecha and @azadDsync, thanks for your interest in helping fix this! Please feel free to work on it and open a PR. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 22, 2024
…lastic#196786) ## Summary Fixes elastic#194751 In `EuiForm`, if the value of `isInvalid` is true, it will render addressFormErrors tip messages. And In `step_logistics.tsx`, `isInValid` is setted by `isInvalid={isSubmitted && !isFormValid}` But form `submit` method set `isSubmitted` to true first, then validate form. At this time, `isSubmitted is true` and `isFormValid is unedfined`. So addressFormErrors shows immediately.  **So, maybe when `isSubmitting` is true, addressFormErrors should not be shown.** Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit f629d96)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 22, 2024
…lastic#196786) ## Summary Fixes elastic#194751 In `EuiForm`, if the value of `isInvalid` is true, it will render addressFormErrors tip messages. And In `step_logistics.tsx`, `isInValid` is setted by `isInvalid={isSubmitted && !isFormValid}` But form `submit` method set `isSubmitted` to true first, then validate form. At this time, `isSubmitted is true` and `isFormValid is unedfined`. So addressFormErrors shows immediately.  **So, maybe when `isSubmitting` is true, addressFormErrors should not be shown.** Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit f629d96)
kibanamachine
added a commit
that referenced
this issue
Oct 22, 2024
…form (#196786) (#197279) # Backport This will backport the following commits from `main` to `8.x`: - [[Index Management] Fix Flashing error banner in Index Template form (#196786)](#196786) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jusheng Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T15:12:12Z","message":"[Index Management] Fix Flashing error banner in Index Template form (#196786)\n\n## Summary\r\n\r\nFixes #194751 \r\n\r\nIn `EuiForm`, if the value of `isInvalid` is true, it will render\r\naddressFormErrors tip messages.\r\n\r\nAnd In `step_logistics.tsx`, `isInValid` is setted by\r\n`isInvalid={isSubmitted && !isFormValid}`\r\n\r\nBut form `submit` method set `isSubmitted` to true first, then validate\r\nform. At this time, `isSubmitted is true` and `isFormValid is\r\nunedfined`. So addressFormErrors shows immediately.\r\n\r\n\r\n\r\n\r\n**So, maybe when `isSubmitting` is true, addressFormErrors should not be\r\nshown.**\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f629d96b85b222fbc3116e6a0a4308882d144aef","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","💝community","v9.0.0","backport:prev-minor","v8.16.0","v8.17.0"],"title":"[Index Management] Fix Flashing error banner in Index Template form","number":196786,"url":"https://github.com/elastic/kibana/pull/196786","mergeCommit":{"message":"[Index Management] Fix Flashing error banner in Index Template form (#196786)\n\n## Summary\r\n\r\nFixes #194751 \r\n\r\nIn `EuiForm`, if the value of `isInvalid` is true, it will render\r\naddressFormErrors tip messages.\r\n\r\nAnd In `step_logistics.tsx`, `isInValid` is setted by\r\n`isInvalid={isSubmitted && !isFormValid}`\r\n\r\nBut form `submit` method set `isSubmitted` to true first, then validate\r\nform. At this time, `isSubmitted is true` and `isFormValid is\r\nunedfined`. So addressFormErrors shows immediately.\r\n\r\n\r\n\r\n\r\n**So, maybe when `isSubmitting` is true, addressFormErrors should not be\r\nshown.**\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f629d96b85b222fbc3116e6a0a4308882d144aef"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196786","number":196786,"mergeCommit":{"message":"[Index Management] Fix Flashing error banner in Index Template form (#196786)\n\n## Summary\r\n\r\nFixes #194751 \r\n\r\nIn `EuiForm`, if the value of `isInvalid` is true, it will render\r\naddressFormErrors tip messages.\r\n\r\nAnd In `step_logistics.tsx`, `isInValid` is setted by\r\n`isInvalid={isSubmitted && !isFormValid}`\r\n\r\nBut form `submit` method set `isSubmitted` to true first, then validate\r\nform. At this time, `isSubmitted is true` and `isFormValid is\r\nunedfined`. So addressFormErrors shows immediately.\r\n\r\n\r\n\r\n\r\n**So, maybe when `isSubmitting` is true, addressFormErrors should not be\r\nshown.**\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f629d96b85b222fbc3116e6a0a4308882d144aef"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jusheng Huang <[email protected]>
kibanamachine
added a commit
that referenced
this issue
Oct 22, 2024
… form (#196786) (#197278) # Backport This will backport the following commits from `main` to `8.16`: - [[Index Management] Fix Flashing error banner in Index Template form (#196786)](#196786) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jusheng Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T15:12:12Z","message":"[Index Management] Fix Flashing error banner in Index Template form (#196786)\n\n## Summary\r\n\r\nFixes #194751 \r\n\r\nIn `EuiForm`, if the value of `isInvalid` is true, it will render\r\naddressFormErrors tip messages.\r\n\r\nAnd In `step_logistics.tsx`, `isInValid` is setted by\r\n`isInvalid={isSubmitted && !isFormValid}`\r\n\r\nBut form `submit` method set `isSubmitted` to true first, then validate\r\nform. At this time, `isSubmitted is true` and `isFormValid is\r\nunedfined`. So addressFormErrors shows immediately.\r\n\r\n\r\n\r\n\r\n**So, maybe when `isSubmitting` is true, addressFormErrors should not be\r\nshown.**\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f629d96b85b222fbc3116e6a0a4308882d144aef","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","💝community","v9.0.0","backport:prev-minor","v8.16.0","v8.17.0"],"title":"[Index Management] Fix Flashing error banner in Index Template form","number":196786,"url":"https://github.com/elastic/kibana/pull/196786","mergeCommit":{"message":"[Index Management] Fix Flashing error banner in Index Template form (#196786)\n\n## Summary\r\n\r\nFixes #194751 \r\n\r\nIn `EuiForm`, if the value of `isInvalid` is true, it will render\r\naddressFormErrors tip messages.\r\n\r\nAnd In `step_logistics.tsx`, `isInValid` is setted by\r\n`isInvalid={isSubmitted && !isFormValid}`\r\n\r\nBut form `submit` method set `isSubmitted` to true first, then validate\r\nform. At this time, `isSubmitted is true` and `isFormValid is\r\nunedfined`. So addressFormErrors shows immediately.\r\n\r\n\r\n\r\n\r\n**So, maybe when `isSubmitting` is true, addressFormErrors should not be\r\nshown.**\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f629d96b85b222fbc3116e6a0a4308882d144aef"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196786","number":196786,"mergeCommit":{"message":"[Index Management] Fix Flashing error banner in Index Template form (#196786)\n\n## Summary\r\n\r\nFixes #194751 \r\n\r\nIn `EuiForm`, if the value of `isInvalid` is true, it will render\r\naddressFormErrors tip messages.\r\n\r\nAnd In `step_logistics.tsx`, `isInValid` is setted by\r\n`isInvalid={isSubmitted && !isFormValid}`\r\n\r\nBut form `submit` method set `isSubmitted` to true first, then validate\r\nform. At this time, `isSubmitted is true` and `isFormValid is\r\nunedfined`. So addressFormErrors shows immediately.\r\n\r\n\r\n\r\n\r\n**So, maybe when `isSubmitting` is true, addressFormErrors should not be\r\nshown.**\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f629d96b85b222fbc3116e6a0a4308882d144aef"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jusheng Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the Index Template form, when we complete the Logistics step and move to another step, an error banner is flashed:
Screen.Recording.2024-10-02.at.18.34.50.mov
I paused the recording and managed to capture the error message being displayed. Interestingly, no errors are displayed for any of the fields in the form.
The text was updated successfully, but these errors were encountered: