Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Licensing] Expose getter in the plugin's start contract #194573

Closed
afharo opened this issue Oct 1, 2024 · 1 comment · Fixed by #194499
Closed

[Licensing] Expose getter in the plugin's start contract #194573

afharo opened this issue Oct 1, 2024 · 1 comment · Fixed by #194499
Assignees
@afharo
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@afharo
Copy link
Member

afharo commented Oct 1, 2024

In #194499, we identified a few instances of plugins calling the refresh() method as a way to await the license's resolution. The problem is that this method forces the retrieval of the license, causing extra load.

To avoid confusion, we can expose a getter that returns a promise that resolves to the license once available.
@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture labels Oct 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo self-assigned this Oct 1, 2024
afharo added a commit to afharo/kibana that referenced this issue Oct 1, 2024
@afharo
Address elastic#194573
8c27ebe
@afharo afharo linked a pull request Oct 1, 2024 that will close this issue
[licensing] Remove unnecessary refresh calls #194499
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[licensing] Remove unnecessary refresh calls afharo/kibana
2 participants
@afharo @elasticmachine