Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metrics:allowCheckingForFailedShards Advanced Setting #193685

Closed
1 task
markov00 opened this issue Sep 23, 2024 · 1 comment · Fixed by #197227
Closed
1 task

Remove metrics:allowCheckingForFailedShards Advanced Setting #193685

markov00 opened this issue Sep 23, 2024 · 1 comment · Fixed by #197227
Assignees
@mbondyra
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@markov00
Copy link
Member

TSVB rendered charts with data from responses where shard failures occur without providing a warning message to the user about the shard failures. This led to misinterpretation of the chart and its data.

After identifying and fixing this issue, the metrics:allowCheckingForFailedShards setting was created and turned ON by default to leave the possibility for the user to return previous behavior (no message displayed and render independently from shard failures).

Shard failures are already displayed within a warning message in multiple places in Kibana. This mechanism is essential to provide a clear understanding of the results visualized in a chart or table.

Tasks:

  • Remove this setting and force the visualization of shard failure warning messages in TSVB by default, with no possibility to suppress it.
@markov00 markov00 added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture labels Sep 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra self-assigned this Oct 22, 2024
@mbondyra mbondyra mentioned this issue Oct 22, 2024
Merged
mbondyra added a commit that referenced this issue Nov 11, 2024
@mbondyra
[TSVB] Remove metrics:allowCheckingForFailedShards Advanced Setting (…
6fc010c 
…#197227)

## Summary

Removes the `metrics:allowCheckingForFailedShards` and doesn't allow to
supress warnings about failed shards in TSVB.

Fixes #193685

### How I tested it

1. Create a TSVB visualization that includes 2024-10-22 day in the time
picker, uses Kibana Ecommerce data view and uses a field
`day_of_week_i`. (This data is only needed if you use the same test data
in point 2)
 
<img width="1499" alt="Screenshot 2024-10-23 at 12 28 21"
src="https://github.com/user-attachments/assets/c341bf22-32d6-4ced-b42d-c4793563d827">

1. On a different tab, edit the `kibana_sample_data_ecommerce` data view
to include all the indices that start from
`kibana_sample_data_ecommerce` (so change the pattern to
`kibana_sample_data_ecommerce*`.

<img width="341" alt="Screenshot 2024-10-23 at 12 24 24"
src="https://github.com/user-attachments/assets/6b718b8b-4f0c-4a9f-ba59-c0bf36727154">

3. Add a new index with a mismatched mapping of a number field to a
string in the dev console.

```
POST /kibana_sample_data_ecommerce_2/_doc
{
  "order_date": "2024-10-22",
  "day_of_week_i": "Hello" 
}
```

Refresh the tab with TSVB visualization:

<img width="1341" alt="Screenshot 2024-10-23 at 12 27 22"
src="https://github.com/user-attachments/assets/fbba8ce0-cdb4-4e59-a53a-6c6229a50a29">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 11, 2024
@mbondyra
[TSVB] Remove metrics:allowCheckingForFailedShards Advanced Setting (…
56c64a4 
…elastic#197227)

## Summary

Removes the `metrics:allowCheckingForFailedShards` and doesn't allow to
supress warnings about failed shards in TSVB.

Fixes elastic#193685

### How I tested it

1. Create a TSVB visualization that includes 2024-10-22 day in the time
picker, uses Kibana Ecommerce data view and uses a field
`day_of_week_i`. (This data is only needed if you use the same test data
in point 2)

<img width="1499" alt="Screenshot 2024-10-23 at 12 28 21"
src="https://github.com/user-attachments/assets/c341bf22-32d6-4ced-b42d-c4793563d827">

1. On a different tab, edit the `kibana_sample_data_ecommerce` data view
to include all the indices that start from
`kibana_sample_data_ecommerce` (so change the pattern to
`kibana_sample_data_ecommerce*`.

<img width="341" alt="Screenshot 2024-10-23 at 12 24 24"
src="https://github.com/user-attachments/assets/6b718b8b-4f0c-4a9f-ba59-c0bf36727154">

3. Add a new index with a mismatched mapping of a number field to a
string in the dev console.

```
POST /kibana_sample_data_ecommerce_2/_doc
{
  "order_date": "2024-10-22",
  "day_of_week_i": "Hello"
}
```

Refresh the tab with TSVB visualization:

<img width="1341" alt="Screenshot 2024-10-23 at 12 27 22"
src="https://github.com/user-attachments/assets/fbba8ce0-cdb4-4e59-a53a-6c6229a50a29">

(cherry picked from commit 6fc010c)
tkajtoch pushed a commit to tkajtoch/kibana that referenced this issue Nov 12, 2024
@mbondyra @tkajtoch
[TSVB] Remove metrics:allowCheckingForFailedShards Advanced Setting (…
faae65b 
…elastic#197227)

## Summary

Removes the `metrics:allowCheckingForFailedShards` and doesn't allow to
supress warnings about failed shards in TSVB.

Fixes elastic#193685

### How I tested it

1. Create a TSVB visualization that includes 2024-10-22 day in the time
picker, uses Kibana Ecommerce data view and uses a field
`day_of_week_i`. (This data is only needed if you use the same test data
in point 2)
 
<img width="1499" alt="Screenshot 2024-10-23 at 12 28 21"
src="https://github.com/user-attachments/assets/c341bf22-32d6-4ced-b42d-c4793563d827">

1. On a different tab, edit the `kibana_sample_data_ecommerce` data view
to include all the indices that start from
`kibana_sample_data_ecommerce` (so change the pattern to
`kibana_sample_data_ecommerce*`.

<img width="341" alt="Screenshot 2024-10-23 at 12 24 24"
src="https://github.com/user-attachments/assets/6b718b8b-4f0c-4a9f-ba59-c0bf36727154">

3. Add a new index with a mismatched mapping of a number field to a
string in the dev console.

```
POST /kibana_sample_data_ecommerce_2/_doc
{
  "order_date": "2024-10-22",
  "day_of_week_i": "Hello" 
}
```

Refresh the tab with TSVB visualization:

<img width="1341" alt="Screenshot 2024-10-23 at 12 27 22"
src="https://github.com/user-attachments/assets/fbba8ce0-cdb4-4e59-a53a-6c6229a50a29">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
@mbondyra @CAWilson94
[TSVB] Remove metrics:allowCheckingForFailedShards Advanced Setting (…
5e41bd8 
…elastic#197227)

## Summary

Removes the `metrics:allowCheckingForFailedShards` and doesn't allow to
supress warnings about failed shards in TSVB.

Fixes elastic#193685

### How I tested it

1. Create a TSVB visualization that includes 2024-10-22 day in the time
picker, uses Kibana Ecommerce data view and uses a field
`day_of_week_i`. (This data is only needed if you use the same test data
in point 2)
 
<img width="1499" alt="Screenshot 2024-10-23 at 12 28 21"
src="https://github.com/user-attachments/assets/c341bf22-32d6-4ced-b42d-c4793563d827">

1. On a different tab, edit the `kibana_sample_data_ecommerce` data view
to include all the indices that start from
`kibana_sample_data_ecommerce` (so change the pattern to
`kibana_sample_data_ecommerce*`.

<img width="341" alt="Screenshot 2024-10-23 at 12 24 24"
src="https://github.com/user-attachments/assets/6b718b8b-4f0c-4a9f-ba59-c0bf36727154">

3. Add a new index with a mismatched mapping of a number field to a
string in the dev console.

```
POST /kibana_sample_data_ecommerce_2/_doc
{
  "order_date": "2024-10-22",
  "day_of_week_i": "Hello" 
}
```

Refresh the tab with TSVB visualization:

<img width="1341" alt="Screenshot 2024-10-23 at 12 27 22"
src="https://github.com/user-attachments/assets/fbba8ce0-cdb4-4e59-a53a-6c6229a50a29">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] Remove metrics:allowCheckingForFailedShards Advanced Setting mbondyra/kibana
3 participants
@markov00 @mbondyra @elasticmachine