[Inventory] Left-hand nav changes for Inventory #193393
Assignees
Labels
enhancement
New value added to drive a business result
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Comments
|
After thoroughly reviewing the code, we found that it's not possible to easily and uniformly add a badge to the four navigation bars we identified in yesterday's sync session. The only one where we can add the badge, because we already have the code in place, is at the O11y level of the Stateful: 'Classic' (see attached screenshot).
After discussing with some colleagues (thanks @crespocarlos and @cauemarcondes ), we believe that adding the badge to the page title (as has traditionally been done) should be sufficient, considering the high complexity of adding the badge to all other navigation bars. Since this feature could be useful, we'll open an issue for the owning teams of those areas to consider adding that capability to their navigation bars. @roshan-elastic Could you please confirm if we're good to proceed with this? Thanks! |
|
There is a side-nav working group #ux-wg-navigation. They are currently working on a new design. Perhaps we could bring the badge topic to them. |
|
After implementing the required changes to the ordering in the different navs, I noticed some details that don't seem to be working correctly from a UI perspective.
@roshan-elastic, do the screenshots of the suggested comments make sense to you? |
Good to know, thank you! I don’t think we should delay the initial release of Inventory because of external work. However, I’ll defer to @roshan-elastic’s opinion on this! |
|
Absolutely, it doesn't make sense to wait for the new design. I shared that in case we want to start a discussion in parallel, for future iterations |
iblancof
added
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
For viz, here's the issue created after talking with #ux-wg-navigation to allow badges in all navigations in all levels 🤞🏻 cc: @crespocarlos |
Hey @iblancof - thanks for looking at this. Re : Stateful classic Good point. What if we move the order down in the O11y nav instead? I think it makes sense to keep all entity-specific things together (so below logs).
Re: Serverless & Stateful new Do the originals look weird if there is spacing?
I think it makes sense for Inventory to be above Infra + Applications because they're all entity-related. WDYT? |
Hey @iblancof - to confirm:
Specifically, it sounds like we can add the tech preview badge on some of the nav bars but not all? So, the proposal is to:
|
|
@roshan-elastic, I'm responding here regarding the badges issue:
The "Technical Preview" badge will appear in the page title, and we can also include it in the Stateful: 'Classic' O11y navigation, which is currently the only one that supports badges.
Yes, but we are not depending on that to release Inventory, it wouldn't make sense to hold up the feature for that reason. |
|
@roshan-elastic, I'm responding here regarding the ordering issue:
Yeah cool, we can have it after logs:
I apologize for not being clear enough in explaining the reasons behind my proposal, rather than simply suggesting adding spaces to the items as you did. I mistakenly believed that we needed to make some changes to the navigation or EUI for this, but it appears that we do not, so we can proceed with it (at least in Stateful : New 'Observability' nav, still need to confirm for Serverless).
|
iblancof
added a commit
that referenced
this issue
Sep 30, 2024
…e nav adjustments (#193533) ## Summary Closes #192323 and #193393. ### Plugin enablement The enablement of the new Inventory plugin was previously managed via the `xpack.inventory.enabled` setting in kibana.yml. With this PR, we transition to enabling it through the `observability:entitycentricexperience` advanced setting. ### Position in side nav Additionally, this PR includes adjustments to the placement of the new Inventory page within the side navigation and the addition of the "Tech Preview" badge in the navigation where it was supported. |Navigation|Screenshot| |-|-| |Stateful classic (first nav)|| |Stateful classic (O11y)|| |Stateful new O11y|| |Serverless|| ### Global search A modification was made to the global search to prevent a duplicate result from appearing during searches by removing the deeplinks when registering the plugin. The UI changes are shown below. >[!WARNING] If this modification causes any other issues, please let me know in a comment. |With deeplink (before)|Without deeplink (after)| |-|-| ||| ### Services rename to Service Inventory Another needed change was to rename the nav item Services to Service Inventory >[!NOTE] Screenshots were taken before the navigation sorting was agreed with product, so the "Inventory" item does not appear in the right position. |Navigation|Screenshot| |-|-| |Stateful classic (O11y)|| |Stateful new O11y|| |Serverless|| >[!NOTE] The rename of infra Inventory to Infrastructure Inventory is being tracked separately in #192324. ### Tech preview badge in page Lastly, the "Technical Preview" badge has been added to the page title. >[!NOTE] The screenshot was taken before the navigation sorting was agreed with product, so the "Inventory" item does not appear in the right position.  ### Plugin registration in server To make the Inventory available in the spaces and privileges configuration the plugin has been registered in the features service. >[!WARNING] I lack detailed context in this area, so I’ve added default empty configurations for most attributes. If any adjustments or improvements are needed, please let me know. |Space config|Privileges| |-|-| ||| --------- Co-authored-by: Kate Patticha <[email protected]> Co-authored-by: kibanamachine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 30, 2024
…e nav adjustments (elastic#193533) ## Summary Closes elastic#192323 and elastic#193393. ### Plugin enablement The enablement of the new Inventory plugin was previously managed via the `xpack.inventory.enabled` setting in kibana.yml. With this PR, we transition to enabling it through the `observability:entitycentricexperience` advanced setting. ### Position in side nav Additionally, this PR includes adjustments to the placement of the new Inventory page within the side navigation and the addition of the "Tech Preview" badge in the navigation where it was supported. |Navigation|Screenshot| |-|-| |Stateful classic (first nav)|| |Stateful classic (O11y)|| |Stateful new O11y|| |Serverless|| ### Global search A modification was made to the global search to prevent a duplicate result from appearing during searches by removing the deeplinks when registering the plugin. The UI changes are shown below. >[!WARNING] If this modification causes any other issues, please let me know in a comment. |With deeplink (before)|Without deeplink (after)| |-|-| ||| ### Services rename to Service Inventory Another needed change was to rename the nav item Services to Service Inventory >[!NOTE] Screenshots were taken before the navigation sorting was agreed with product, so the "Inventory" item does not appear in the right position. |Navigation|Screenshot| |-|-| |Stateful classic (O11y)|| |Stateful new O11y|| |Serverless|| >[!NOTE] The rename of infra Inventory to Infrastructure Inventory is being tracked separately in elastic#192324. ### Tech preview badge in page Lastly, the "Technical Preview" badge has been added to the page title. >[!NOTE] The screenshot was taken before the navigation sorting was agreed with product, so the "Inventory" item does not appear in the right position.  ### Plugin registration in server To make the Inventory available in the spaces and privileges configuration the plugin has been registered in the features service. >[!WARNING] I lack detailed context in this area, so I’ve added default empty configurations for most attributes. If any adjustments or improvements are needed, please let me know. |Space config|Privileges| |-|-| ||| --------- Co-authored-by: Kate Patticha <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 26f5e14)
kibanamachine
added a commit
that referenced
this issue
Sep 30, 2024
… + side nav adjustments (#193533) (#194408) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments (#193533)](#193533) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T10:37:37Z","message":"[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments (#193533)\n\n## Summary\r\n\r\nCloses #192323 and\r\nhttps://github.com//issues/193393.\r\n\r\n### Plugin enablement\r\nThe enablement of the new Inventory plugin was previously managed via\r\nthe `xpack.inventory.enabled` setting in kibana.yml. With this PR, we\r\ntransition to enabling it through the\r\n`observability:entitycentricexperience` advanced setting.\r\n\r\n\r\n### Position in side nav\r\nAdditionally, this PR includes adjustments to the placement of the new\r\nInventory page within the side navigation and the addition of the \"Tech\r\nPreview\" badge in the navigation where it was supported.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic (first nav)||\r\n|Stateful classic (O11y)||\r\n|Stateful new O11y||\r\n|Serverless||\r\n\r\n\r\n### Global search\r\nA modification was made to the global search to prevent a duplicate\r\nresult from appearing during searches by removing the deeplinks when\r\nregistering the plugin. The UI changes are shown below.\r\n\r\n>[!WARNING]\r\nIf this modification causes any other issues, please let me know in a\r\ncomment.\r\n\r\n|With deeplink (before)|Without deeplink (after)|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Services rename to Service Inventory\r\nAnother needed change was to rename the nav item Services to Service\r\nInventory\r\n\r\n>[!NOTE] \r\nScreenshots were taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic\r\n(O11y)||\r\n|Stateful new\r\nO11y||\r\n\r\n|Serverless||\r\n\r\n>[!NOTE] \r\nThe rename of infra Inventory to Infrastructure Inventory is being\r\ntracked separately in https://github.com/elastic/kibana/issues/192324.\r\n\r\n\r\n### Tech preview badge in page\r\nLastly, the \"Technical Preview\" badge has been added to the page title.\r\n\r\n>[!NOTE] \r\nThe screenshot was taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Plugin registration in server\r\nTo make the Inventory available in the spaces and privileges\r\nconfiguration the plugin has been registered in the features service.\r\n\r\n>[!WARNING]\r\nI lack detailed context in this area, so I’ve added default empty\r\nconfigurations for most attributes. If any adjustments or improvements\r\nare needed, please let me know.\r\n\r\n|Space config|Privileges|\r\n|-|-|\r\n|||\r\n\r\n---------\r\n\r\nCo-authored-by: Kate Patticha <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"26f5e1482b23548d1b06bec9e5fedf7dfa93a620","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0"],"title":"[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments","number":193533,"url":"https://github.com/elastic/kibana/pull/193533","mergeCommit":{"message":"[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments (#193533)\n\n## Summary\r\n\r\nCloses #192323 and\r\nhttps://github.com//issues/193393.\r\n\r\n### Plugin enablement\r\nThe enablement of the new Inventory plugin was previously managed via\r\nthe `xpack.inventory.enabled` setting in kibana.yml. With this PR, we\r\ntransition to enabling it through the\r\n`observability:entitycentricexperience` advanced setting.\r\n\r\n\r\n### Position in side nav\r\nAdditionally, this PR includes adjustments to the placement of the new\r\nInventory page within the side navigation and the addition of the \"Tech\r\nPreview\" badge in the navigation where it was supported.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic (first nav)||\r\n|Stateful classic (O11y)||\r\n|Stateful new O11y||\r\n|Serverless||\r\n\r\n\r\n### Global search\r\nA modification was made to the global search to prevent a duplicate\r\nresult from appearing during searches by removing the deeplinks when\r\nregistering the plugin. The UI changes are shown below.\r\n\r\n>[!WARNING]\r\nIf this modification causes any other issues, please let me know in a\r\ncomment.\r\n\r\n|With deeplink (before)|Without deeplink (after)|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Services rename to Service Inventory\r\nAnother needed change was to rename the nav item Services to Service\r\nInventory\r\n\r\n>[!NOTE] \r\nScreenshots were taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic\r\n(O11y)||\r\n|Stateful new\r\nO11y||\r\n\r\n|Serverless||\r\n\r\n>[!NOTE] \r\nThe rename of infra Inventory to Infrastructure Inventory is being\r\ntracked separately in https://github.com/elastic/kibana/issues/192324.\r\n\r\n\r\n### Tech preview badge in page\r\nLastly, the \"Technical Preview\" badge has been added to the page title.\r\n\r\n>[!NOTE] \r\nThe screenshot was taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Plugin registration in server\r\nTo make the Inventory available in the spaces and privileges\r\nconfiguration the plugin has been registered in the features service.\r\n\r\n>[!WARNING]\r\nI lack detailed context in this area, so I’ve added default empty\r\nconfigurations for most attributes. If any adjustments or improvements\r\nare needed, please let me know.\r\n\r\n|Space config|Privileges|\r\n|-|-|\r\n|||\r\n\r\n---------\r\n\r\nCo-authored-by: Kate Patticha <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"26f5e1482b23548d1b06bec9e5fedf7dfa93a620"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193533","number":193533,"mergeCommit":{"message":"[Inventory] Use observability:entitycentricexperience to enable + side nav adjustments (#193533)\n\n## Summary\r\n\r\nCloses #192323 and\r\nhttps://github.com//issues/193393.\r\n\r\n### Plugin enablement\r\nThe enablement of the new Inventory plugin was previously managed via\r\nthe `xpack.inventory.enabled` setting in kibana.yml. With this PR, we\r\ntransition to enabling it through the\r\n`observability:entitycentricexperience` advanced setting.\r\n\r\n\r\n### Position in side nav\r\nAdditionally, this PR includes adjustments to the placement of the new\r\nInventory page within the side navigation and the addition of the \"Tech\r\nPreview\" badge in the navigation where it was supported.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic (first nav)||\r\n|Stateful classic (O11y)||\r\n|Stateful new O11y||\r\n|Serverless||\r\n\r\n\r\n### Global search\r\nA modification was made to the global search to prevent a duplicate\r\nresult from appearing during searches by removing the deeplinks when\r\nregistering the plugin. The UI changes are shown below.\r\n\r\n>[!WARNING]\r\nIf this modification causes any other issues, please let me know in a\r\ncomment.\r\n\r\n|With deeplink (before)|Without deeplink (after)|\r\n|-|-|\r\n\r\n|||\r\n\r\n### Services rename to Service Inventory\r\nAnother needed change was to rename the nav item Services to Service\r\nInventory\r\n\r\n>[!NOTE] \r\nScreenshots were taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n|Navigation|Screenshot|\r\n|-|-|\r\n|Stateful classic\r\n(O11y)||\r\n|Stateful new\r\nO11y||\r\n\r\n|Serverless||\r\n\r\n>[!NOTE] \r\nThe rename of infra Inventory to Infrastructure Inventory is being\r\ntracked separately in https://github.com/elastic/kibana/issues/192324.\r\n\r\n\r\n### Tech preview badge in page\r\nLastly, the \"Technical Preview\" badge has been added to the page title.\r\n\r\n>[!NOTE] \r\nThe screenshot was taken before the navigation sorting was agreed with\r\nproduct, so the \"Inventory\" item does not appear in the right position.\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Plugin registration in server\r\nTo make the Inventory available in the spaces and privileges\r\nconfiguration the plugin has been registered in the features service.\r\n\r\n>[!WARNING]\r\nI lack detailed context in this area, so I’ve added default empty\r\nconfigurations for most attributes. If any adjustments or improvements\r\nare needed, please let me know.\r\n\r\n|Space config|Privileges|\r\n|-|-|\r\n|||\r\n\r\n---------\r\n\r\nCo-authored-by: Kate Patticha <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"26f5e1482b23548d1b06bec9e5fedf7dfa93a620"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Update the various left-hand side navs to account for the new inventory:
Stateful : Classic nav (first nav)
Stateful : Classic nav (O11y nav)
Stateful : New 'Observability' nav
Serverless : Nav
✔️ Acceptance criteria
1. Must Have
Must be delivered in this issue in order for the release to be valuable
4. Will Not Have (for now)
Explicitly will not be looked at within this issue
The text was updated successfully, but these errors were encountered: