Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory] Handle empty states #193336

Closed
kpatticha opened this issue Sep 18, 2024 · 1 comment · Fixed by #193755
Closed

[Inventory] Handle empty states #193336

kpatticha opened this issue Sep 18, 2024 · 1 comment · Fixed by #193755
Assignees
@kpatticha
Labels
enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@kpatticha
Copy link
Contributor

Summary

Show empty state when EEM is enabled but the cluster has no data in the cluster or the eem enginee (data tranforms) processing the data

Designs

Caution

Please review the designs on Figma - DESIGNS

(Screenshot taken on 18.09.2024)

Image

Acceptance criteria

  • if the entities latest index doesn't return any data for the entity types [services, hosts, containers ] show the empty state and the callout
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 18, 2024
@kpatticha kpatticha added enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Feature:EntitiesInventory Observability entities inventory feature labels Sep 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 18, 2024
@cauemarcondes cauemarcondes mentioned this issue Sep 20, 2024
Merged
@kpatticha kpatticha self-assigned this Sep 23, 2024
@kpatticha kpatticha mentioned this issue Sep 23, 2024
Merged
kpatticha added a commit that referenced this issue Sep 24, 2024
@kpatticha @kibanamachine
[Inventory][ECO] Show empty state when no entities are found. (#193755)
476b9f5 
## Summary

closes #193336 


- Introduce route `GET /internal/inventory/has_data` that check if there
are any entities for hosts, services and containers
- Show empty state
- Refactor a bit the button to add data to reuse it

**Note**:
- I used the illustration we had for the new service inventory as it had
the dark version.
- The callout will be shown by default. (I dismissed before starting the
recording)

### without entities

https://github.com/user-attachments/assets/6c5f7f38-a31c-4801-9e3d-3c91edd88f1d

### with entities


https://github.com/user-attachments/assets/19de8215-1c11-4c36-bae4-00432f205855

---------

Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 24, 2024
@kpatticha
[Inventory][ECO] Show empty state when no entities are found. (elasti…
f9f43f4 
…c#193755)

## Summary

closes elastic#193336

- Introduce route `GET /internal/inventory/has_data` that check if there
are any entities for hosts, services and containers
- Show empty state
- Refactor a bit the button to add data to reuse it

**Note**:
- I used the illustration we had for the new service inventory as it had
the dark version.
- The callout will be shown by default. (I dismissed before starting the
recording)

### without entities

https://github.com/user-attachments/assets/6c5f7f38-a31c-4801-9e3d-3c91edd88f1d

### with entities

https://github.com/user-attachments/assets/19de8215-1c11-4c36-bae4-00432f205855

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 476b9f5)
kibanamachine added a commit that referenced this issue Sep 24, 2024
@kibanamachine @kpatticha
[8.x] [Inventory][ECO] Show empty state when no entities are found. (#…
b26edac 
…193755) (#193904)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] Show empty state when no entities are found.
(#193755)](#193755)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T17:15:26Z","message":"[Inventory][ECO]
Show empty state when no entities are found. (#193755)\n\n##
Summary\r\n\r\ncloses #193336 \r\n\r\n\r\n- Introduce route `GET
/internal/inventory/has_data` that check if there\r\nare any entities
for hosts, services and containers\r\n- Show empty state\r\n- Refactor a
bit the button to add data to reuse it\r\n\r\n**Note**:\r\n- I used the
illustration we had for the new service inventory as it had\r\nthe dark
version.\r\n- The callout will be shown by default. (I dismissed before
starting the\r\nrecording)\r\n\r\n### without
entities\r\n\r\nhttps://github.com/user-attachments/assets/6c5f7f38-a31c-4801-9e3d-3c91edd88f1d\r\n\r\n###
with
entities\r\n\r\n\r\nhttps://github.com/user-attachments/assets/19de8215-1c11-4c36-bae4-00432f205855\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"476b9f5ba767d391236cd026da13fd939863abe1","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory][ECO]
Show empty state when no entities are
found.","number":193755,"url":"https://github.com/elastic/kibana/pull/193755","mergeCommit":{"message":"[Inventory][ECO]
Show empty state when no entities are found. (#193755)\n\n##
Summary\r\n\r\ncloses #193336 \r\n\r\n\r\n- Introduce route `GET
/internal/inventory/has_data` that check if there\r\nare any entities
for hosts, services and containers\r\n- Show empty state\r\n- Refactor a
bit the button to add data to reuse it\r\n\r\n**Note**:\r\n- I used the
illustration we had for the new service inventory as it had\r\nthe dark
version.\r\n- The callout will be shown by default. (I dismissed before
starting the\r\nrecording)\r\n\r\n### without
entities\r\n\r\nhttps://github.com/user-attachments/assets/6c5f7f38-a31c-4801-9e3d-3c91edd88f1d\r\n\r\n###
with
entities\r\n\r\n\r\nhttps://github.com/user-attachments/assets/19de8215-1c11-4c36-bae4-00432f205855\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"476b9f5ba767d391236cd026da13fd939863abe1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193755","number":193755,"mergeCommit":{"message":"[Inventory][ECO]
Show empty state when no entities are found. (#193755)\n\n##
Summary\r\n\r\ncloses #193336 \r\n\r\n\r\n- Introduce route `GET
/internal/inventory/has_data` that check if there\r\nare any entities
for hosts, services and containers\r\n- Show empty state\r\n- Refactor a
bit the button to add data to reuse it\r\n\r\n**Note**:\r\n- I used the
illustration we had for the new service inventory as it had\r\nthe dark
version.\r\n- The callout will be shown by default. (I dismissed before
starting the\r\nrecording)\r\n\r\n### without
entities\r\n\r\nhttps://github.com/user-attachments/assets/6c5f7f38-a31c-4801-9e3d-3c91edd88f1d\r\n\r\n###
with
entities\r\n\r\n\r\nhttps://github.com/user-attachments/assets/19de8215-1c11-4c36-bae4-00432f205855\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"476b9f5ba767d391236cd026da13fd939863abe1"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Katerina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpatticha kpatticha

Labels
enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Inventory][ECO] Show empty state when no entities are found. kpatticha/kibana
2 participants
@kpatticha @elasticmachine