Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show TSVB and Agg based as "legacy" when users create a visualization from the library #191489

Closed
Tracked by #198136
teresaalvarezsoler opened this issue Aug 27, 2024 · 6 comments · Fixed by #195966
Closed
Tracked by #198136
Assignees
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@teresaalvarezsoler
Copy link

teresaalvarezsoler commented Aug 27, 2024

Problem
Currently, we don't have a way to discourage user from creating TSVB and Agg based visualizations. We should let users know that TSVB and Agg based will be deprecated in the future so they can choose Lens or ESQL visualizations instead.

Image

Solution
Show TSVB and Agg based as "legacy" like we do in the Dashboards. Needs design @MichaelMarcialis

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 27, 2024
@teresaalvarezsoler teresaalvarezsoler added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed needs-team Issues missing a team label labels Aug 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@teresaalvarezsoler teresaalvarezsoler added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Aug 27, 2024
@MichaelMarcialis MichaelMarcialis self-assigned this Aug 27, 2024
@teresaalvarezsoler teresaalvarezsoler added triage_needed loe:small Small Level of Effort and removed triage_needed labels Sep 4, 2024
@MichaelMarcialis
Copy link
Contributor

The latest Figma design mockups for this issue have been crafted and are ready for handoff to engineering. Some key screenshots from the mockups can be found below. Please view the full Figma document for all mockups and developer notes.


Image

Image

Image

@markov00
Copy link
Member

markov00 commented Oct 1, 2024

@teresaalvarezsoler @MichaelMarcialis should we provide the deprecation message also within the various editors?
I believe we should right? Michael could you provide a quick design for that if Teresa agree?
Thanks

@markov00
Copy link
Member

markov00 commented Oct 1, 2024

@MichaelMarcialis I've discussed with Teresa and the current Legacy tooltip should be a bit more vague "are scheduled for deprecation in the future" or something along those lines.

At a later stage, we are going to:

  • show an icon/text in the deprecated dashboard panels saying that we are deprecating the viz
  • add the deprecation message inside the editor
  • add a way to convert or support the migration to Lens

@markov00
Copy link
Member

markov00 commented Oct 1, 2024

@florent-leborgne @gvnmagni it will be great if you folks could craft a better text to describe the various editors. We can make this modal shine and convince more users to switch to Lens if we have better warding here.
Thanks

@florent-leborgne
Copy link
Contributor

@markov00 I think the current approach already discourages from going with the legacy ones.
Maybe we can still:

  • reinforce the messaging on the Legacy pane by adding somewhere that Lens provides these features and even more, with a link to switch back to it instead?
  • rework the text of the Lens card to insist that this is the best and most complete editor available there? Maybe we can reinforce the way it looks visually as well

I'm not sure if it's worth revisiting the texts on all other cards as they are rather factual and specific, unless you have a particular idea in mind?

@mbondyra mbondyra self-assigned this Oct 11, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 21, 2024
…e visualizations from the library (elastic#195966)

## Summary

Fixes elastic#191489

Redesign of "Create Visualization" Modal

To encourage users to adopt Lens and reduce reliance on Agg-based and
TSVB visualizations, we've redesigned the "Create Visualization" modal.
The new layout now features two distinct tabs: one highlighting
recommended visualizations, and another clearly marking legacy options.
This separation ensures users are well-informed about which
visualization types are preferred moving forward.

<img width="757" alt="Screenshot 2024-10-15 at 13 15 49"
src="https://github.com/user-attachments/assets/fe353504-5511-46ab-aef4-5a340650027b">

![image](https://github.com/user-attachments/assets/86c399fc-e737-453f-84e3-938d85aa22d3)

(cherry picked from commit 46eda4c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
7 participants