Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvas][maps] by-value map embeddables have broken layers #190994

Closed
nreese opened this issue Aug 21, 2024 · 1 comment · Fixed by #190996
Closed

[canvas][maps] by-value map embeddables have broken layers #190994

nreese opened this issue Aug 21, 2024 · 1 comment · Fixed by #190996
Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0

Comments

@nreese
Copy link
Contributor

nreese commented Aug 21, 2024 •
edited
Loading

Background

Canvas is missing support for by-value reference injection and extraction. Original issue #101639 closed by #123515. The closing PR only added migration support, not reference injection and extraction.

steps

  1. create new canvas workpad
  2. Click "Select type" and select "Maps"
  3. Add a documents layer to your map and click "Save and return"
  4. Click "canvas" bread crumb to go back to canvas listing page
  5. Open you work pad again. Notice how the map is now broken
Screenshot 2024-08-21 at 8 50 31 AM
@nreese nreese added the bug Fixes for quality problems that affect the customer experience label Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
@nreese nreese mentioned this issue Aug 21, 2024
Merged
@nreese nreese added regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas project:embeddableRebuild v8.15.0 labels Aug 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 21, 2024
@nreese nreese closed this as completed in 1da0967 Aug 21, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 21, 2024
@nreese
[canvas] fix by-value map embeddables have broken layers (elastic#190996
34125e8 
)

Resolves elastic#190994

### Test instructions
1. create new canvas workpad
2. Click "Select type" and select "Maps"
3. Add a documents layer to your map and click "Save and return"
4. Click "canvas" bread crumb to go back to canvas listing page
5. Open you work pad again. Map should still display data

(cherry picked from commit 1da0967)
kibanamachine referenced this issue Aug 21, 2024
@kibanamachine @nreese
[8.15] [canvas] fix by-value map embeddables have broken layers (#190996
0669c37 
) (#191011)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[canvas] fix by-value map embeddables have broken layers
(#190996)](#190996)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-21T17:19:35Z","message":"[canvas]
fix by-value map embeddables have broken layers (#190996)\n\nResolves
https://github.com/elastic/kibana/issues/190994\r\n\r\n### Test
instructions\r\n1. create new canvas workpad\r\n2. Click \"Select type\"
and select \"Maps\"\r\n3. Add a documents layer to your map and click
\"Save and return\"\r\n4. Click \"canvas\" bread crumb to go back to
canvas listing page\r\n5. Open you work pad again. Map should still
display
data","sha":"1da096793d775d9dacafc6a744b84caf5cb2a5eb","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","project:embeddableRebuild","v8.16.0","v8.15.1"],"title":"[canvas]
fix by-value map embeddables have broken
layers","number":190996,"url":"https://github.com/elastic/kibana/pull/190996","mergeCommit":{"message":"[canvas]
fix by-value map embeddables have broken layers (#190996)\n\nResolves
https://github.com/elastic/kibana/issues/190994\r\n\r\n### Test
instructions\r\n1. create new canvas workpad\r\n2. Click \"Select type\"
and select \"Maps\"\r\n3. Add a documents layer to your map and click
\"Save and return\"\r\n4. Click \"canvas\" bread crumb to go back to
canvas listing page\r\n5. Open you work pad again. Map should still
display
data","sha":"1da096793d775d9dacafc6a744b84caf5cb2a5eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190996","number":190996,"mergeCommit":{"message":"[canvas]
fix by-value map embeddables have broken layers (#190996)\n\nResolves
https://github.com/elastic/kibana/issues/190994\r\n\r\n### Test
instructions\r\n1. create new canvas workpad\r\n2. Click \"Select type\"
and select \"Maps\"\r\n3. Add a documents layer to your map and click
\"Save and return\"\r\n4. Click \"canvas\" bread crumb to go back to
canvas listing page\r\n5. Open you work pad again. Map should still
display
data","sha":"1da096793d775d9dacafc6a744b84caf5cb2a5eb"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
@nreese nreese mentioned this issue Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[canvas] fix by-value map embeddables have broken layers nreese/kibana
2 participants
@nreese @elasticmachine