Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable Rebuild] [Controls] Unsaved changes stuck after adding new control + resetting #190988

Closed
Heenawter opened this issue Aug 21, 2024 · 4 comments
Closed

[Embeddable Rebuild] [Controls] Unsaved changes stuck after adding new control + resetting #190988

Heenawter opened this issue Aug 21, 2024 · 4 comments
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Aug 21, 2024 •
edited
Loading

Steps to reproduce:

  1. Navigate to the Controls page in the examples plugin
  2. Add a new control
  3. Click reset
  4. Control is removed, but the control group is still reporting unsaved changes 🔥

Expected behavior:
Unsaved changes should be cleared.

Screenshots (if relevant):

Screen.Recording.2024-08-21.at.8.09.23.AM.mov
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. project:embeddableRebuild labels Aug 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor

nreese commented Aug 21, 2024

Closed in #190273. If you want, I could move the fix into its own PR

fa502fa

@Heenawter
Copy link
Contributor Author

Oh!! That's awesome, thanks🖖 I'm personally good if you just link this issue to that PR - up to you though

@nreese nreese mentioned this issue Aug 21, 2024
Merged
@nreese nreese mentioned this issue Aug 23, 2024
Closed
nreese added a commit that referenced this issue Aug 30, 2024
@nreese @elasticmachine
@kibanamachine @Heenawter
Integrate react control group embeddable into dashboard container (#1…
c272d97 
…90273)

closes #191137,
#190988,
#191155

PR replaces legacy embeddable control group implementation with react
control group implementation in DashboardContainer.

### Test instructions
1. Open dashboard via dashboard application or portable dashboard
2. Mess around with controls. There should be no changes in behavior

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Hannah Mudge <[email protected]>
@nreese
Copy link
Contributor

nreese commented Aug 30, 2024

Closed by #190273

@nreese nreese closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nreese @Heenawter @elasticmachine