[Embeddable Rebuild] [Controls] Refactor ControlGroupRenderer
#189820
Assignees
Labels
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
loe:large
Large Level of Effort
Project:Controls
project:embeddableRebuild
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
Heenawter
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
This was referenced Aug 8, 2024
Heenawter
added
loe:large
Heenawter
added a commit
that referenced
this issue
Sep 10, 2024
… framework (#190561) Closes #189820 ### Summary This PR converts the `ControlGroupRenderer` to use the new control group embeddable, which is built on the new React embeddable framework. With this conversion, there should not be **any** changes in user-facing behaviour - therefore, testing of this PR should be focused on ensuring that no behaviour is changed and/or broken with this refactor. **Notes to Solution Reviewers:** - There should be minimal changes to your uses of `ControlGroupRenderer` - our goal here was to keep the exposed API more-or-less consistent with this refactor. Therefore, most changes are simply renames + changes of imports. - That being said, `updateInput` and `getInput$` are **very much** tied to the old embeddable infrastructure - so while they will continue to work for now, they have been deprecated in favour of adding setters/getters for the parts of the control group state that you need to update / respond to. **Notes to Presentation Reviewer:** - The bundle size was originally being increased by this PR, so I decided to remove a bunch of the public exports that are no longer necessary as a final cleanup - this resulted in changes to imports in a few files, but it was worth doing in this PR IMO so that we didn't have to increase the Controls bundle limit. Now, this PR shrinks the bundle size 🎉 - I fixed a small bug with the default value of `showApplySelections` in this PR - since it was a one-line change, if felt like overkill to separate it out. See https://github.com/elastic/kibana/pull/190561/files#r1733253015 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I will be refactoring the
ControlGroupRendererin the examples plugin, and the refactored version will be moved to thecontrolsplugin alongside everything else 👍 The goal here is to keep the props + API the same, so that we won't have to change anything in the consumer's plugins.The text was updated successfully, but these errors were encountered: