Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Open links in new tab' markdown setting doesn't apply until refresh #18949

Closed
ppisljar opened this issue May 9, 2018 · 0 comments
Closed

'Open links in new tab' markdown setting doesn't apply until refresh #18949

ppisljar opened this issue May 9, 2018 · 0 comments
Assignees
@markov00
Labels
bug Fixes for quality problems that affect the customer experience Feature:Markdown Markdown visualization feature Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@ppisljar
Copy link
Member

ppisljar commented May 9, 2018

In markdown visualization changing the open links in new tab has no effect until refresh.

Option is applied only when component is constructed and is not updated anymore.
@ppisljar ppisljar added bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Markdown Markdown visualization feature labels May 9, 2018
@markov00 markov00 self-assigned this May 23, 2018
@markov00 markov00 mentioned this issue May 24, 2018
Merged
markov00 added a commit to markov00/kibana that referenced this issue May 24, 2018
@markov00
Fix rendering markdown when updating open in new tab setting (elastic…
337772c 
…#18949)

- Moved set the link target behaviour outside the constructor
- Minor style fixes
markov00 added a commit that referenced this issue May 24, 2018
@markov00
Fix rendering markdown when updating open in new tab setting (#19356)
e662b48 
* Fix rendering markdown when updating open in new tab setting (#18949)

- Moved set the link target behaviour outside the constructor
- Minor style fixes

* Refactoring: recreate markdownit if openLinksInNewTab changes. Add test

* Move props checking conditions to variables. Add test for whiteListedRules prop change

* Add checks before changing the props
markov00 added a commit to markov00/kibana that referenced this issue May 24, 2018
@markov00
Fix rendering markdown when updating open in new tab setting (elastic…
4c55ad2 
…#19356)

* Fix rendering markdown when updating open in new tab setting (elastic#18949)

- Moved set the link target behaviour outside the constructor
- Minor style fixes

* Refactoring: recreate markdownit if openLinksInNewTab changes. Add test

* Move props checking conditions to variables. Add test for whiteListedRules prop change

* Add checks before changing the props
markov00 added a commit that referenced this issue May 24, 2018
@markov00
Fix rendering markdown when updating open in new tab setting (#19356) (…
af594e8 
…#19388)

* Fix rendering markdown when updating open in new tab setting (#18949)

- Moved set the link target behaviour outside the constructor
- Minor style fixes

* Refactoring: recreate markdownit if openLinksInNewTab changes. Add test

* Move props checking conditions to variables. Add test for whiteListedRules prop change

* Add checks before changing the props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Fixes for quality problems that affect the customer experience Feature:Markdown Markdown visualization feature Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markov00 @ppisljar