Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Timeline loading infinitely in some cases #188942

Closed
logeekal opened this issue Jul 23, 2024 · 3 comments
Closed

[Security Solution] Timeline loading infinitely in some cases #188942

logeekal opened this issue Jul 23, 2024 · 3 comments
Assignees
@logeekal
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team

Comments

@logeekal
Copy link
Contributor

Describe the bug:
Timeline goes in inifinite loop.

Kibana/Elasticsearch Stack version:
8.15 and main

Steps to reproduce:

  1. Navigate to Timelines
  2. Open a new timeline
  3. Make any search request which has live data coming in ( very important )
  4. The timeline will keep on loading forever. Below is the video from Endpoint instance.
Bildschirmaufnahme.2024-07-23.um.15.07.32.mov

Current behavior:

Never finishing loading in some cases after fetching the records.

Expected behavior:
Should finish loading after fetching all the records.
Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context (logs, chat logs, magical formulas, etc.):
@logeekal logeekal added bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team labels Jul 23, 2024
@logeekal logeekal self-assigned this Jul 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@logeekal logeekal mentioned this issue Jul 23, 2024
Merged
logeekal added a commit that referenced this issue Jul 23, 2024
@logeekal
[Security Solution ] Fixes Timeline infinite loading bug (#188943)
b098522 
## Summary

handles #188942

There was a hook which was causing additionall re-renders. Removed that.
Timeline should be working fine. Below you can see that timeline works
fine with multiple time-ranges. The original issue did not always occur
consistently, only when there was a change in events fetched.



https://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 23, 2024
@logeekal
[Security Solution ] Fixes Timeline infinite loading bug (elastic#188943
610ce71 
)

## Summary

handles elastic#188942

There was a hook which was causing additionall re-renders. Removed that.
Timeline should be working fine. Below you can see that timeline works
fine with multiple time-ranges. The original issue did not always occur
consistently, only when there was a change in events fetched.

https://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b
(cherry picked from commit b098522)
kibanamachine referenced this issue Jul 23, 2024
@kibanamachine @logeekal
[8.15] [Security Solution ] Fixes Timeline infinite loading bug (#188943
a7760d0 
) (#188996)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security Solution ] Fixes Timeline infinite loading bug
(#188943)](#188943)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-23T18:31:09Z","message":"[Security
Solution ] Fixes Timeline infinite loading bug (#188943)\n\n##
Summary\r\n\r\nhandles
https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook
which was causing additionall re-renders. Removed that.\r\nTimeline
should be working fine. Below you can see that timeline works\r\nfine
with multiple time-ranges. The original issue did not always
occur\r\nconsistently, only when there was a change in events
fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","backport:prev-minor","v8.16.0"],"title":"[Security
Solution ] Fixes Timeline infinite loading
bug","number":188943,"url":"https://github.com/elastic/kibana/pull/188943","mergeCommit":{"message":"[Security
Solution ] Fixes Timeline infinite loading bug (#188943)\n\n##
Summary\r\n\r\nhandles
https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook
which was causing additionall re-renders. Removed that.\r\nTimeline
should be working fine. Below you can see that timeline works\r\nfine
with multiple time-ranges. The original issue did not always
occur\r\nconsistently, only when there was a change in events
fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188943","number":188943,"mergeCommit":{"message":"[Security
Solution ] Fixes Timeline infinite loading bug (#188943)\n\n##
Summary\r\n\r\nhandles
https://github.com/elastic/kibana/issues/188942\r\n\r\nThere was a hook
which was causing additionall re-renders. Removed that.\r\nTimeline
should be working fine. Below you can see that timeline works\r\nfine
with multiple time-ranges. The original issue did not always
occur\r\nconsistently, only when there was a change in events
fetched.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/861e5501-f857-40bc-989e-a5a0e565585b","sha":"b0985227bab9b9345d5ac217a89ac659f30d4865"}}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <[email protected]>
@logeekal
Copy link
Contributor Author

logeekal commented Oct 1, 2024

fixed by #188943

@logeekal logeekal closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@logeekal logeekal

Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@logeekal @elasticmachine