Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome UI Functional Tests.test/functional/apps/discover/group2_data_grid3/_data_grid_row_height·ts - discover/group2/data_grid3 discover data grid row height should allow to change header row height #182785

Closed
kibanamachine opened this issue May 7, 2024 · 1 comment · Fixed by #183896
Closed

Failing test: Chrome UI Functional Tests.test/functional/apps/discover/group2_data_grid3/_data_grid_row_height·ts - discover/group2/data_grid3 discover data grid row height should allow to change header row height #182785

kibanamachine opened this issue May 7, 2024 · 1 comment · Fixed by #183896
Assignees
@jughosta
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: expected '' to equal 'Single'
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:227:8)
    at Assertion.be (expect.js:69:22)
    at Context.<anonymous> (_data_grid_row_height.ts:111:66)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:73:16)

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label May 7, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label May 7, 2024
@kibanamachine kibanamachine added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label May 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 7, 2024
@kertal kertal added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels May 7, 2024
@jughosta jughosta mentioned this issue May 21, 2024
Merged
jughosta added a commit that referenced this issue May 22, 2024
@jughosta
[Discover] Fix flaky data grid header row height test (#183896)
95510c1 
- Closes #182785

30x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6055
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 22, 2024
@jughosta
[Discover] Fix flaky data grid header row height test (elastic#183896)
a0c3a15 
- Closes elastic#182785

30x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6055

(cherry picked from commit 95510c1)
kibanamachine referenced this issue May 22, 2024
@kibanamachine @jughosta
[8.14] [Discover] Fix flaky data grid header row height test (#183896) (
aaf5239 
#183983)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Discover] Fix flaky data grid header row height test
(#183896)](#183896)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-22T07:16:23Z","message":"[Discover]
Fix flaky data grid header row height test (#183896)\n\n- Closes
https://github.com/elastic/kibana/issues/182785\r\n\r\n30x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6055","sha":"95510c1d83753fd90f23da447a53943d6e28c39b","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.15.0"],"title":"[Discover]
Fix flaky data grid header row height
test","number":183896,"url":"https://github.com/elastic/kibana/pull/183896","mergeCommit":{"message":"[Discover]
Fix flaky data grid header row height test (#183896)\n\n- Closes
https://github.com/elastic/kibana/issues/182785\r\n\r\n30x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6055","sha":"95510c1d83753fd90f23da447a53943d6e28c39b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183896","number":183896,"mergeCommit":{"message":"[Discover]
Fix flaky data grid header row height test (#183896)\n\n- Closes
https://github.com/elastic/kibana/issues/182785\r\n\r\n30x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6055","sha":"95510c1d83753fd90f23da447a53943d6e28c39b"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Fix flaky data grid header row height test jughosta/kibana
4 participants
@kertal @jughosta @elasticmachine @kibanamachine