Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Remove Logs Explorer #182229

Open
gbamparop opened this issue May 1, 2024 · 2 comments · May be fixed by #203685
Open

[Logs Explorer] Remove Logs Explorer #182229

gbamparop opened this issue May 1, 2024 · 2 comments · May be fixed by #203685
Assignees
Labels
9.0 candidate Project:OneDiscover Enrich Discover with contextual awareness Team:obs-ux-logs Observability Logs User Experience Team

Comments

@gbamparop
Copy link
Contributor

gbamparop commented May 1, 2024

📓 Summary

Once Discover has full awareness of different data types to offer a curated experience, we won't need anymore to differentiate it from the Logs Explorer using 2 different apps, Vanilla Discover and Logs Explorer.

Screenshot 2024-05-08 at 14 46 12

✔️ Acceptance criteria

  • The available tabs on the top navbar, currently "Discover" and "Logs Explorer", should be removed from every environment.
  • Redirect deep links to discover
  • Remove logs explorer links in other applications and change them to discover links
  • Stretch (can be done in a follow-up): The code for Logs Explorer will be removed from Kibana

❓ Pending questions

  • How should links to discover look in other applications?
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Project:OneDiscover Enrich Discover with contextual awareness labels May 1, 2024
@weltenwort
Copy link
Member

This is blocked by the availability of a data source selector in Discover, which supports the features of the Logs Explorer data selector, right?

@gbamparop
Copy link
Contributor Author

This issue should be the last item of the first phase for One Discover (MVP). Currently, the data source selector is part of that phase but there would be further discussions.

@gbamparop gbamparop changed the title [Logs Explorer] Remove Logs Explorer tab [Logs Explorer] Remove Logs Explorer Dec 3, 2024
@thomheymann thomheymann self-assigned this Dec 4, 2024
@thomheymann thomheymann linked a pull request Dec 12, 2024 that will close this issue
gbamparop added a commit that referenced this issue Dec 19, 2024
## Release note
Logs Stream and the logs settings page in Observability are removed. Use
the [Discover](https://www.elastic.co/guide/en/kibana/current/discover.html) application,
which now offers a contextual experience for logs, to explore your logs.
The logs stream panel in dashboards is removed, use Discover sessions
instead.

## 📓 Summary
The Logs Stream app in Observability and the log stream panel available
in dashboards were hidden behind an advanced setting as part of
#194519 in `8.16.0`. At the same
time, a link was added to the left navigation for the logs settings
page.

This PR which targets `9.0.0` disables these pages as well as the
dashboard panel:
- Removes the navigation item for the logs settings page and the
corresponding route
- Removes the `observability:enableLogsStream` setting and keeps the
redirects to logs explorer. The locators will be updated to point to
Discover as part of #182229.

Removing the code that renders the logs stream and the settings pages
will be done in a [follow-up
issue](#204005).

### Left navigation

#### Classic
<img width="238" alt="image"
src="https://github.com/user-attachments/assets/bc72c5ce-ed32-472e-91c1-8bd691dd2420"
/>

#### Solution
<img width="275" alt="image"
src="https://github.com/user-attachments/assets/3b21a2ae-5e82-478e-97bb-e12303178a24"
/>

### Navigating to /app/logs/settings
<img width="1722" alt="image"
src="https://github.com/user-attachments/assets/07b4197c-6063-4a59-8194-a97ce2fa3cd7"
/>


Closes elastic/observability-dev#4156

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
## Release note
Logs Stream and the logs settings page in Observability are removed. Use
the [Discover](https://www.elastic.co/guide/en/kibana/current/discover.html) application,
which now offers a contextual experience for logs, to explore your logs.
The logs stream panel in dashboards is removed, use Discover sessions
instead.

## 📓 Summary
The Logs Stream app in Observability and the log stream panel available
in dashboards were hidden behind an advanced setting as part of
elastic#194519 in `8.16.0`. At the same
time, a link was added to the left navigation for the logs settings
page.

This PR which targets `9.0.0` disables these pages as well as the
dashboard panel:
- Removes the navigation item for the logs settings page and the
corresponding route
- Removes the `observability:enableLogsStream` setting and keeps the
redirects to logs explorer. The locators will be updated to point to
Discover as part of elastic#182229.

Removing the code that renders the logs stream and the settings pages
will be done in a [follow-up
issue](elastic#204005).

### Left navigation

#### Classic
<img width="238" alt="image"
src="https://github.com/user-attachments/assets/bc72c5ce-ed32-472e-91c1-8bd691dd2420"
/>

#### Solution
<img width="275" alt="image"
src="https://github.com/user-attachments/assets/3b21a2ae-5e82-478e-97bb-e12303178a24"
/>

### Navigating to /app/logs/settings
<img width="1722" alt="image"
src="https://github.com/user-attachments/assets/07b4197c-6063-4a59-8194-a97ce2fa3cd7"
/>


Closes elastic/observability-dev#4156

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 candidate Project:OneDiscover Enrich Discover with contextual awareness Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants