Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Implement data source context flavor resolution #182106

Closed
Tracked by #181728
kertal opened this issue Apr 30, 2024 · 2 comments
Closed
Tracked by #181728

[Discover] Implement data source context flavor resolution #182106

kertal opened this issue Apr 30, 2024 · 2 comments
Labels
enhancement New value added to drive a business result Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Apr 30, 2024

🚧 Work in progress. Placeholder issue for implementing the flavor resolution process 🚧

Today Discover supports three different data sources:

  • ES|QL query
  • Data view (persisted and ad hoc)
  • Saved search (contains an ES|QL query or data view reference)

For One Discover, this list will need to extend to an unknown number of data sources, which the current URL structure and application state are not well suited for. To support this requirement, we will introduce an abstraction called a “data source” which represents some target for data exploration in Discover. An example of a new data source type would be “integration”.

type DiscoverDataSource =
  | { type: 'esql'; query: string }
  | { type: 'dataView'; dataViewId: string }
  | { type: 'savedSearch'; savedSearchId: string }
  | { type: 'integration'; integrationIds: string[] };
``

During the context resolution process, the data source will be used to fetch associated metadata, such as indices and fields, and then normalized to an internal structure Discover knows how to handle.

Additionally, the resolution process will return a data source context, used to make decisions about which code paths to follow in the flavor layer. 
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 30, 2024
@kertal kertal added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Apr 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 30, 2024
@kertal kertal added needs-team Issues missing a team label Project:OneDiscover Enrich Discover with contextual awareness labels Apr 30, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 30, 2024
@kertal kertal added the enhancement New value added to drive a business result label Apr 30, 2024
@kertal kertal changed the title [Discover] Implement flavor resolution process based on data source context [Discover] Implement data source context flavor resolution May 14, 2024
@kertal
Copy link
Member Author

kertal commented May 21, 2024

Closing, is part of #181962

@kertal kertal closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

2 participants