Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps][embeddable rebuild] replace usages of MapEmbeddable with react Component #182020

Closed
5 tasks done
nreese opened this issue Apr 29, 2024 · 2 comments
Closed
5 tasks done

[maps][embeddable rebuild] replace usages of MapEmbeddable with react Component #182020

nreese opened this issue Apr 29, 2024 · 2 comments
Assignees
@nreese @nickpeihl
Labels
Feature:Maps project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Apr 29, 2024 •
edited by ThomThomson
Loading

Prerequisite for #174960

All usages of Map embeddable must be replaced before Map embeddable can be refactored to react embeddable.

Usages:
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps project:embeddableRebuild labels Apr 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese mentioned this issue Apr 29, 2024
Merged
nreese added a commit that referenced this issue May 1, 2024
@nreese @kibanamachine
[ML] Decouple data_visualizer from MapEmbeddable (#181928)
1e8d51a 
Part of #182020

### test instructions
1. install web logs sample data
2. Open discover
3. In table, click "Field statistics"
4. Expand `geo.dest` row. Verify choropleth map is displayed.
5. Expand `geo.coordinates` row. Verify vector map is displayed.

---------

Co-authored-by: kibanamachine <[email protected]>
@nreese nreese mentioned this issue May 2, 2024
Merged
@nreese nreese mentioned this issue May 6, 2024
Merged
nreese added a commit that referenced this issue May 7, 2024
@nreese @kibanamachine
[ML] decouple ML plugin from Map embeddable (#182409)
8c20433 
Part of #182020

---------

Co-authored-by: Kibana Machine <[email protected]>
nreese added a commit that referenced this issue May 13, 2024
@nreese @kibanamachine
[embeddable refactor] decouple MapEmbeddable from Security Solution p…
1c15e9a 
…lugin (#182737)

Part of #182020

@elastic/kibana-presentation is refactoring the Embeddable framework.
Part of this effort is decoupling plugins from the legacy Embeddable
framework. The Maps plugin provides a react component from the plugins
start contract that can be used instead of natively using MapEmbeddable.

This PR swaps out the native MapEmbeddable implementation with the react
component exposed from the Maps plugin.

---------

Co-authored-by: Kibana Machine <[email protected]>
@ThomThomson
Copy link
Contributor

Closing this because the work has been finished. Nice @nickpeihl & @nreese!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

@nickpeihl nickpeihl

Labels
Feature:Maps project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nreese @nickpeihl @ThomThomson @elasticmachine