-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Custom threshold] Equation label is not used in the preview chart tooltip #181876
Labels
bug
Fixes for quality problems that affect the customer experience
Feature: Custom threshold
Observability custom threshold rule type
Team:obs-ux-management
Observability Management User Experience Team
Comments
maryam-saeidi
added
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-management
Observability Management User Experience Team
Feature: Custom threshold
Observability custom threshold rule type
labels
Apr 26, 2024
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
maryam-saeidi
added a commit
that referenced
this issue
Nov 12, 2024
…chart (#199618) Fixes #181876 ## Summary This PR fixes the custom equation label on the preview lens chart. |With label|Without label|With group by field| |---|---|---| |![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 12, 2024
…chart (elastic#199618) Fixes elastic#181876 ## Summary This PR fixes the custom equation label on the preview lens chart. |With label|Without label|With group by field| |---|---|---| |![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)| (cherry picked from commit 8668757)
kibanamachine
added a commit
that referenced
this issue
Nov 12, 2024
… lens chart (#199618) (#199770) # Backport This will backport the following commits from `main` to `8.x`: - [[Custom threshold] Fix the custom equation label on the preview lens chart (#199618)](#199618) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T12:01:36Z","message":"[Custom threshold] Fix the custom equation label on the preview lens chart (#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the custom equation label on the preview lens chart.\r\n\r\n|With label|Without label|With group by field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Custom threshold] Fix the custom equation label on the preview lens chart","number":199618,"url":"https://github.com/elastic/kibana/pull/199618","mergeCommit":{"message":"[Custom threshold] Fix the custom equation label on the preview lens chart (#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the custom equation label on the preview lens chart.\r\n\r\n|With label|Without label|With group by field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199618","number":199618,"mergeCommit":{"message":"[Custom threshold] Fix the custom equation label on the preview lens chart (#199618)\n\nFixes #181876\r\n\r\n## Summary\r\n\r\nThis PR fixes the custom equation label on the preview lens chart.\r\n\r\n|With label|Without label|With group by field|\r\n|---|---|---|\r\n\r\n|![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|","sha":"8668757459feca8b5792662d2dacd07b0bf94e74"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <[email protected]>
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this issue
Nov 12, 2024
…chart (elastic#199618) Fixes elastic#181876 ## Summary This PR fixes the custom equation label on the preview lens chart. |With label|Without label|With group by field| |---|---|---| |![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Nov 18, 2024
…chart (elastic#199618) Fixes elastic#181876 ## Summary This PR fixes the custom equation label on the preview lens chart. |With label|Without label|With group by field| |---|---|---| |![image](https://github.com/user-attachments/assets/b4f1a1e7-8e67-4b24-ae48-379fe393f90a)|![image](https://github.com/user-attachments/assets/3ef2733f-9ce8-4b37-8ecf-c19c1371aced)|![image](https://github.com/user-attachments/assets/d638f49e-98e2-4df7-8852-84dc62b9f739)|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature: Custom threshold
Observability custom threshold rule type
Team:obs-ux-management
Observability Management User Experience Team
Summary
In the custom threshold, we don't use the equation label on the preview chart similar to what we have in the metric threshold rule:
The text was updated successfully, but these errors were encountered: