[Embeddables Rebuild] O11y Migrate Flame Graph #179293
Assignees
Labels
Feature:Embeddables
Relating to the Embeddable system
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
loe:small
Small Level of Effort
project:embeddableRebuild
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
ThomThomson
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
added a commit
that referenced
this issue
Jun 13, 2024
…legacy embeddable factory (#184466) Fixes #179290, #179291, #179292, #179293 Part of #167429 ## Summary Decouples the legacy embeddable factory from O11y profiling plugin. The class-based embeddable factory is being removed in preference to a [React embeddable factory](#167429). The profiling plugin was using the legacy embeddable factory to register profiling components that could be shared to other observability plugins. While not strictly enforced, the embeddable registry is expected to be used _only_ for embedding components into Dashboards and Canvas. The embeddables registered by the Profiling plugin were never made available to Dashboards or Canvas. And based on offline discussions with Observability leadership, it is not expected that Profiling components will be made available for embedding on Dashboards or Canvas in the near future. In this PR, I have removed the legacy embeddable usage from the Profiling plugin. The Observability shared plugin now includes a custom registration method for the profiling plugin to register React components so they can be shared to other plugins. This avoids any circular dependency concerns while still allowing other Observability plugins to "embed" profiling components in their pages.
|
Fixed by #184466 |
Heenawter
added
loe:small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of the Embeddable refactor, we will need to migrate the O11y Flamegraph embeddable located in
x-pack/plugins/observability_solution/profiling/public/embeddables/flamegraph/embeddable_flamegraph_factory.tsThe text was updated successfully, but these errors were encountered: