-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing ES Forward Compatibility: Default CI Group #6 / Uptime app with real-world data uptime ml anomaly can create job successfully #179166
Comments
Skipped. 7.17: dd53060 |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
@jasonrhodes any updates on this? |
@rayafratkina we are looking into it. If the test has been skipped, can someone help us understand how it's still blocking something? We may end up removing this test due to changes in Uptime/Heartbeat, but we'll get back to you ASAP. |
Caught up with @jasonrhodes offline, but for the record: we skip failed integration tests (failed-ed-promotion label) in order to avoid blocking everyone, but we expect the responsible team to investigate ASAP to determine if the failure does, in fact, indicate something in Kibana is impacted by an ES change. The failed-es-promotion issue should be assigned and the owner should report the outcome of the investigation and any planned actions in the issue. If it is determined there is no way to address the failure so we can re-enable the test in a timely manner, please consider removing the test until a replacement can be added back and track this work on your team's backlog and not as a skipped test. |
I've investigated this failure, increasing the timeout on the test and running the test in flaky test runner for 200 iterations, for which it has passed. I'm not sure though if i need to be testing in a different way. Should I be testing against a specific version of ES @rayafratkina ? |
@mistic @rayafratkina do you have an guidance on how we make sure we've tested this correctly? Thanks! |
@dominiqueclarke do you feel like we have what we need to confidently close this, or do we need more input from @mistic / @rayafratkina / @elastic/kibana-core re: testing this with the right ES? |
I think @elastic/kibana-operations can help better with the steps. I think there are some env vars to be set to ensure that we run 8.x ES when Kibana is still in 7.17. It looks like the promotion job was removed, so I'm not sure if this is still relevant? |
It's resolved, it will automatically be picked up after the test is unskipped. I don't see any issues with closing this out. |
Thanks! Forgive me but I don't really understand the process for this kind of issue.
Is this something we need to know how to do to test something like this? Is this for local testing, or for CI?
What does this mean? What's the "promotion job" and what does it mean that it's been removed?
What's been resolved? And how does this test get unskipped?
I'm happy to close this once we are sure we understand the above, thanks. |
Yes for local testing. There will be a comment in the build (example) with instructions. This pipeline is testing Kibana 7.17 against supported versions of Elasticsearch 8, the environment variable will override the Elasticsearch snapshot version to emulate what CI is doing.
We run all Kibana tests against new Elasticsearch builds of the same version before they're 'promoted' to Kibana development. We do this to prevent Elasticsearch bugs from blocking Kibana development and CI. This isn't a promotion job, it's a daily run of Kibana 7.17 against the most recent promoted version of Elasticsearch 8. I'll take it back to the team to make sure we're aligned and remove the promotion label. Regarding removal, afharo is referring to logs missing for https://buildkite.com/elastic/kibana-7-dot-17-es-8-dot-14-forward-compatibility/builds/42. There was a refactor and the pipelines were removed in the process. It's still relevant, but the pipeline is at https://buildkite.com/elastic/kibana-es-forward-compatibility-testing now.
Generally, for releases, we need the the blocker label triaged. For closing the issue we need the test unskipped or removed. Thanks for the thorough questions! We're reviewing this in the near future and the feedback is helpful. |
Closed by #193310. |
Thanks for the explanations, @jbudz !! |
Chrome X-Pack UI Functional Tests
x-pack/test/functional/apps/uptime/ml_anomaly.ts
Uptime app with real-world data uptime ml anomaly can create job successfully
This failure is preventing the ES 8.14 forward compatibility pipeline to proceed.
The text was updated successfully, but these errors were encountered: