Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Button label under Recently created cases on Detection & Response dashboard should be View All Cases instead of View recent cases #177808

Closed
arvindersingh-qasource opened this issue Feb 27, 2024 · 7 comments
Closed

[Enhancement] Button label under Recently created cases on Detection & Response dashboard should be View All Cases instead of View recent cases #177808

arvindersingh-qasource opened this issue Feb 27, 2024 · 7 comments
Assignees
@kapral18
Labels
enhancement New value added to drive a business result QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.13.0

Comments

@arvindersingh-qasource
Copy link

Describe the bug
Button label under Recently created cases on Detection & Response dashboard should be View All Cases instead of View recent cases

Build Details

VERSION: 8.13.0
BUILD: 71738
COMMIT: b036a9705a55f6c81d065011ad8c991cbc3101d9

Browser Details
This issue is occurring on all browsers.

Preconditions

  1. Kibana v8.13.0 should be available.
  2. Cases must be created.

Steps to Reproduce

  1. Navigate to Security -> Dashboards
  2. Open Detection & Response dashboard
  3. Observe that Button label under Recently created cases on Detection & Response dashboard is View recent cases whereas it navigates to All Cases tab.

Additional Information

  • We are using the build which is upgraded from 7.17.18 > 8.13.0

Actual Result
Button label under Recently created cases on Detection & Response dashboard is View recent cases whereas it navigates to All Cases tab.

Expected Result
Button label under Recently created cases on Detection & Response dashboard should be View All Cases instead of View recent cases

What's Working

  • N/A

What's Not Working

  • N/A

Screen shot

2
@arvindersingh-qasource arvindersingh-qasource added enhancement New value added to drive a business result Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.13.0 labels Feb 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@arvindersingh-qasource
Copy link
Author

@karanbirsingh-qasource Please review this ticket.

Thanks.

@ghost ghost assigned MadameSheema and unassigned ghost Feb 27, 2024
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels Feb 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@michaelolo24 michaelolo24 removed their assignment Mar 7, 2024
@michaelolo24 michaelolo24 added Team:Threat Hunting:Explore and removed Team:Threat Hunting:Investigations Security Solution Investigations Team labels Mar 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@kapral18 kapral18 self-assigned this Mar 8, 2024
kapral18 added a commit to kapral18/kibana that referenced this issue Mar 8, 2024
@kapral18
improve(security_solution): switch 'recent' to 'all' in 'View recent …
3c7334a 
…cases'

- in detection & response dashboard fix the button label for viewing all
  cases

fix for: elastic#177808
@kapral18 kapral18 mentioned this issue Mar 8, 2024
Merged
kapral18 added a commit that referenced this issue Mar 8, 2024
@kapral18
[Security Solution][Detection & Response] Fix view all cases button l…
552e8ad 
…abel (#178325)

fix for: #177808

## Summary

In detection & response dashboard button label to all cases has a wrong
label mentioning "View recent cases".
This PR fixes it and changes it to "View all cases".

Before:
<img width="1496" alt="image"
src="https://github.com/elastic/kibana/assets/1625373/0f0834b9-30f2-435a-ba5e-3f5046cf719d">

After:
<img width="1496" alt="image"
src="https://github.com/elastic/kibana/assets/1625373/d23066d7-0312-499a-bdd6-aefeb063c9dc">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 8, 2024
@kapral18
[Security Solution][Detection & Response] Fix view all cases button l…
7b70ee8 
…abel (elastic#178325)

fix for: elastic#177808

## Summary

In detection & response dashboard button label to all cases has a wrong
label mentioning "View recent cases".
This PR fixes it and changes it to "View all cases".

Before:
<img width="1496" alt="image"
src="https://github.com/elastic/kibana/assets/1625373/0f0834b9-30f2-435a-ba5e-3f5046cf719d">

After:
<img width="1496" alt="image"
src="https://github.com/elastic/kibana/assets/1625373/d23066d7-0312-499a-bdd6-aefeb063c9dc">

(cherry picked from commit 552e8ad)
kibanamachine added a commit that referenced this issue Mar 8, 2024
@kibanamachine @kapral18
[8.13] [Security Solution][Detection &amp; Response] Fix view all cas…
ad7c080 
…es button label (#178325) (#178339)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Security Solution][Detection &amp; Response] Fix view all cases
button label (#178325)](#178325)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Karen
Grigoryan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-08T17:12:25Z","message":"[Security
Solution][Detection & Response] Fix view all cases button label
(#178325)\n\nfix for: #177808\r\n\r\n## Summary\r\n\r\nIn detection &
response dashboard button label to all cases has a wrong\r\nlabel
mentioning \"View recent cases\".\r\nThis PR fixes it and changes it to
\"View all cases\".\r\n\r\nBefore:\r\n<img width=\"1496\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1625373/0f0834b9-30f2-435a-ba5e-3f5046cf719d\">\r\n\r\nAfter:\r\n<img
width=\"1496\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1625373/d23066d7-0312-499a-bdd6-aefeb063c9dc\">","sha":"552e8adcca053bbe13cbc087eb7cd6cad473dbb2","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","v8.13.0","v8.14.0"],"title":"[Security
Solution][Detection & Response] Fix view all cases button
label","number":178325,"url":"https://github.com/elastic/kibana/pull/178325","mergeCommit":{"message":"[Security
Solution][Detection & Response] Fix view all cases button label
(#178325)\n\nfix for: #177808\r\n\r\n## Summary\r\n\r\nIn detection &
response dashboard button label to all cases has a wrong\r\nlabel
mentioning \"View recent cases\".\r\nThis PR fixes it and changes it to
\"View all cases\".\r\n\r\nBefore:\r\n<img width=\"1496\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1625373/0f0834b9-30f2-435a-ba5e-3f5046cf719d\">\r\n\r\nAfter:\r\n<img
width=\"1496\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1625373/d23066d7-0312-499a-bdd6-aefeb063c9dc\">","sha":"552e8adcca053bbe13cbc087eb7cd6cad473dbb2"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178325","number":178325,"mergeCommit":{"message":"[Security
Solution][Detection & Response] Fix view all cases button label
(#178325)\n\nfix for: #177808\r\n\r\n## Summary\r\n\r\nIn detection &
response dashboard button label to all cases has a wrong\r\nlabel
mentioning \"View recent cases\".\r\nThis PR fixes it and changes it to
\"View all cases\".\r\n\r\nBefore:\r\n<img width=\"1496\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1625373/0f0834b9-30f2-435a-ba5e-3f5046cf719d\">\r\n\r\nAfter:\r\n<img
width=\"1496\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1625373/d23066d7-0312-499a-bdd6-aefeb063c9dc\">","sha":"552e8adcca053bbe13cbc087eb7cd6cad473dbb2"}}]}]
BACKPORT-->

Co-authored-by: Karen Grigoryan <[email protected]>
@kapral18
Copy link
Contributor

kapral18 commented Mar 8, 2024

@arvindersingh-qasource fix is merged to main. check please

@ghost
Copy link

ghost commented Mar 12, 2024

Hi @kapral18

we have checked the mains and requested enhancement is now available.

image

Hence we are closing this ticket.

thanks !!

@ghost ghost closed this as completed Mar 12, 2024
@ghost ghost added the QA:Validated Issue has been validated by QA label Mar 12, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kapral18 kapral18

Labels
enhancement New value added to drive a business result QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kapral18 @elasticmachine @michaelolo24 @MadameSheema @arvindersingh-qasource