-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subActionsParams to connector definition validate fields. #177025
Comments
Pinging @elastic/response-ops (Team:ResponseOps) |
I think moving them to the connector's type definition will reduce the simplicity of the sub-actions framework and make the connector's type definition more complex. The sub-action framework uses the actions framework behind the scenes. The schema of the sub-action connectors is defined and passed to the actions framework here. We could enhance the framework to expose the schema of the parameters of the sub-actions without having to instantiate the class (connector). For example, |
Resolves: #177025 I figured out a way to get the SubActions schemas and used it rather than the suggested way in the issue. ## To verify: Change one of the SubAction's schema and run the integration test, It should fail.
Follow-on of: #175018
We are testing connector type config, secrets and params schemas in order to be notified when there is a change on them.
But, as SubActionConnectorTypes doesn't have their params schemas listed in anywhere, couldn't test them.
They are registered during the action execution: e.g. https://github.com/ersin-erdal/kibana/blob/main/x-pack/plugins/stack_connectors/server/connector_types/bedrock/bedrock.ts#L57
We can move them in to connectorType definition schema object and create in a for loop during execution, so we can have a list to check against changes.
The text was updated successfully, but these errors were encountered: