Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global Search] Using search to find Canvas workpads requires quotations #176877

Closed
tsullivan opened this issue Feb 14, 2024 · 3 comments · Fixed by #196087
Closed

[Global Search] Using search to find Canvas workpads requires quotations #176877

tsullivan opened this issue Feb 14, 2024 · 3 comments · Fixed by #196087
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana good first issue low hanging fruit Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

tsullivan commented Feb 14, 2024

A user may expect to find their Canvas content by searching for type:canvas however the reality is a bad UX: the type is "canvas workpad". If the user leaves out the quotation marks, there will be no results.

image
@tsullivan tsullivan added the bug Fixes for quality problems that affect the customer experience label Feb 14, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 14, 2024
@tsullivan tsullivan added Feature:Search Querying infrastructure in Kibana Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Feb 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 14, 2024
@petrklapka
Copy link
Member

@tsullivan - would you consider this a good first issue for our new hires?

@tsullivan
Copy link
Member Author

@petrklapka yes, this looks like a good one for getting started with shared-ux services

@petrklapka petrklapka added the good first issue low hanging fruit label Sep 19, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Oct 11, 2024
kowalczyk-krzysztof added a commit that referenced this issue Oct 16, 2024
## Summary

This PR improves the UX of global search by allowing users to search for
types that consist of multiple words without having to turn them into
phrases (wrapping them in quotes).

For example: 

The following query:
```
hello type:canvas workpad type:enterprise search world tag:new
```
Will get mapped to:
```
hello type:"canvas workpad" type:"enterprise search" world tag:new
```
Which will result in following `Query` object:
```json
{
  "term": "hello world",
  "filters": {
    "tags": ["new"]
    "types": ["canvas workpad", "enterprise search"],
   },
}
```

Fixes: #176877

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 16, 2024
…#196087)

## Summary

This PR improves the UX of global search by allowing users to search for
types that consist of multiple words without having to turn them into
phrases (wrapping them in quotes).

For example:

The following query:
```
hello type:canvas workpad type:enterprise search world tag:new
```
Will get mapped to:
```
hello type:"canvas workpad" type:"enterprise search" world tag:new
```
Which will result in following `Query` object:
```json
{
  "term": "hello world",
  "filters": {
    "tags": ["new"]
    "types": ["canvas workpad", "enterprise search"],
   },
}
```

Fixes: elastic#176877

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 3d28d17)
kibanamachine added a commit that referenced this issue Oct 16, 2024
…196087) (#196545)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Global Search] Add multiword type handling in global search
(#196087)](#196087)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T12:29:03Z","message":"[Global
Search] Add multiword type handling in global search (#196087)\n\n##
Summary\r\n\r\nThis PR improves the UX of global search by allowing
users to search for\r\ntypes that consist of multiple words without
having to turn them into\r\nphrases (wrapping them in
quotes).\r\n\r\nFor example: \r\n\r\nThe following
query:\r\n```\r\nhello type:canvas workpad type:enterprise search world
tag:new\r\n```\r\nWill get mapped to:\r\n```\r\nhello type:\"canvas
workpad\" type:\"enterprise search\" world tag:new\r\n```\r\nWhich will
result in following `Query` object:\r\n```json\r\n{\r\n \"term\":
\"hello world\",\r\n \"filters\": {\r\n \"tags\": [\"new\"]\r\n
\"types\": [\"canvas workpad\", \"enterprise search\"],\r\n
},\r\n}\r\n```\r\n\r\nFixes: #176877\r\n\r\n### Checklist\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"3d28d173a94dc9856fe43cbff8d88ac4e2d42a17","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"[Global
Search] Add multiword type handling in global
search","number":196087,"url":"https://github.com/elastic/kibana/pull/196087","mergeCommit":{"message":"[Global
Search] Add multiword type handling in global search (#196087)\n\n##
Summary\r\n\r\nThis PR improves the UX of global search by allowing
users to search for\r\ntypes that consist of multiple words without
having to turn them into\r\nphrases (wrapping them in
quotes).\r\n\r\nFor example: \r\n\r\nThe following
query:\r\n```\r\nhello type:canvas workpad type:enterprise search world
tag:new\r\n```\r\nWill get mapped to:\r\n```\r\nhello type:\"canvas
workpad\" type:\"enterprise search\" world tag:new\r\n```\r\nWhich will
result in following `Query` object:\r\n```json\r\n{\r\n \"term\":
\"hello world\",\r\n \"filters\": {\r\n \"tags\": [\"new\"]\r\n
\"types\": [\"canvas workpad\", \"enterprise search\"],\r\n
},\r\n}\r\n```\r\n\r\nFixes: #176877\r\n\r\n### Checklist\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"3d28d173a94dc9856fe43cbff8d88ac4e2d42a17"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196087","number":196087,"mergeCommit":{"message":"[Global
Search] Add multiword type handling in global search (#196087)\n\n##
Summary\r\n\r\nThis PR improves the UX of global search by allowing
users to search for\r\ntypes that consist of multiple words without
having to turn them into\r\nphrases (wrapping them in
quotes).\r\n\r\nFor example: \r\n\r\nThe following
query:\r\n```\r\nhello type:canvas workpad type:enterprise search world
tag:new\r\n```\r\nWill get mapped to:\r\n```\r\nhello type:\"canvas
workpad\" type:\"enterprise search\" world tag:new\r\n```\r\nWhich will
result in following `Query` object:\r\n```json\r\n{\r\n \"term\":
\"hello world\",\r\n \"filters\": {\r\n \"tags\": [\"new\"]\r\n
\"types\": [\"canvas workpad\", \"enterprise search\"],\r\n
},\r\n}\r\n```\r\n\r\nFixes: #176877\r\n\r\n### Checklist\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"3d28d173a94dc9856fe43cbff8d88ac4e2d42a17"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana good first issue low hanging fruit Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants