-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Entity Analytics] Remove before and after hooks from Cypress tests #175023
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
👋 Hey there @MadameSheema! Is there a list of test cases that need to have this change made? If not, I'll get with the team to assess how many instances of this we have within Entity Analytics tests. Additionally, do we have a timeline for when we want this completed for the second quality gate? |
Edit: missed that this is only relevant for cypress tests 🤦 so no need for tasks currently these are the files I found based on our code ownership, going to split into 2 subtasks, one for cypress and one for integration
|
@MadameSheema could you confirm if we should do the same for FTR tests, or only for Cypress? (regarding @hop-dev 's comment above) |
Cypress :) |
PR ready just runnning flaky test runner #177175 Only very small changes were needed, we primarily used only the archiver in our before and after calls. |
Relates to:
#173327
#174247
Get rid of the
before
andafter
hooks in favor of thebeforeEach
andafterEach
hooks. Or at least make sure that the code executed in the before and after hook is not prone to fail (i.e. es_archiver).The text was updated successfully, but these errors were encountered: