Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Detection Engine] Remove before and after hooks from Cypress tests #175021

Closed
Tracked by #153633
, #173327
...
MadameSheema opened this issue Jan 17, 2024 · 2 comments
Closed
Tracked by #153633
, #173327
...

[Detection Engine] Remove before and after hooks from Cypress tests #175021

MadameSheema opened this issue Jan 17, 2024 · 2 comments
Labels
Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@MadameSheema
Copy link
Member

Relates to:

#173327
#174247

Get rid of the before and after hooks in favor of the beforeEach and afterEach hooks. Or at least make sure that the code executed in the before and after hook is not prone to fail (i.e. es_archiver).
@MadameSheema MadameSheema added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Jan 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@MadameSheema MadameSheema mentioned this issue Jan 17, 2024
Open
43 tasks
@banderror banderror mentioned this issue Feb 12, 2024
Open
@MadameSheema MadameSheema mentioned this issue Mar 18, 2024
Merged
MadameSheema added a commit that referenced this issue Mar 19, 2024
@MadameSheema
[Security Solution][Detection Engine] Getting rid off before hook if …
e0829c0 
…is not loading an archive (#178876)

## Summary

Addresses: #175021

Before the introduced changes on this PR, we had test dependency at
`manage_lists_cy.ts`. Now that the dependency does not exist anymore, we
had to update the assertions.

Update:
[Flaky test suite runner passed
successfully](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elasticmachine @MadameSheema