Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explore] Remove before and after hooks from Cypress tests #175020

Closed
Tracked by #173327
MadameSheema opened this issue Jan 17, 2024 · 2 comments
Closed
Tracked by #173327

[Explore] Remove before and after hooks from Cypress tests #175020

MadameSheema opened this issue Jan 17, 2024 · 2 comments
Labels
Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@MadameSheema
Copy link
Member

Relates to:

#173327
#174247

Get rid of the before and after hooks in favor of the beforeEach and afterEach hooks. Or at least make sure that the code executed in the before and after hook is not prone to fail (i.e. es_archiver).
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore labels Jan 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@MadameSheema MadameSheema changed the title [Explore] Remove beofre and after hooks from Cypress tests [Explore] Remove before and after hooks from Cypress tests Jan 17, 2024
@MadameSheema MadameSheema mentioned this issue Jan 17, 2024
Open
43 tasks
@MadameSheema MadameSheema mentioned this issue Mar 18, 2024
Merged
MadameSheema added a commit that referenced this issue Mar 19, 2024
@MadameSheema
[Security Solution][Explore][Cypress] Getting rid off before hook if …
e90d7fe 
…is not loading an archive (#178870)

## Summary

Addresses: #175020

Update:

- [Flaky test suite runner passed
successfully](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elasticmachine @MadameSheema