Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability alerts table] Improve default alert table fields #174239

Closed
3 tasks
maryam-saeidi opened this issue Jan 4, 2024 · 7 comments · Fixed by #175119
Closed
3 tasks

[Observability alerts table] Improve default alert table fields #174239

maryam-saeidi opened this issue Jan 4, 2024 · 7 comments · Fixed by #175119
Assignees
Labels
Feature:Alerting Team:obs-ux-management Observability Management User Experience Team v8.13.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Jan 4, 2024

🍒 Summary

The current set of default fields in the alert table is not useful enough for our users. Based on a feedback (author: @elkargig ) provided by @roshan-elastic and some SRE interviews that @maciejforcone did, we would like to change the default alert table fields to the following:

  1. Triggered
  2. Duration
  3. Rule name
    • rule name (on hover: show rule category)
  4. source
    • group by field
  5. Observed value
  6. Difference
    • diff of observed and threshold (show threshold on hover)
  7. Tags

Also, we would like to adjust the default time range to 2 hours instead of 15 mins.

🎯 Acceptance Criteria

  • Adjust the default list of alerts table columns as mentioned above
  • Change the default time range to 2 hours

What will be covered in separate PR

@maryam-saeidi maryam-saeidi added Feature:Alerting Team:obs-ux-management Observability Management User Experience Team v8.13.0 labels Jan 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@roshan-elastic
Copy link

Hey @maryam-saeidi - thanks for picking this up! I was trying to figure out which table this was but I couldn't find the fields in the UI.

Do you have a rough mock-up/screenshot of the now vs proposed?

Note : Even if it's just annotations of what would change that would be super helpful

@maryam-saeidi maryam-saeidi self-assigned this Jan 17, 2024
@maryam-saeidi
Copy link
Member Author

Hi @roshan-elastic,

Sorry for the late reply, here is roughly what the old and new tables look like:

Old alert table New alert table
image image

There are still some things missing that I am working on, including:

  1. A column to show the difference between the observed value and threshold.
  2. Making sure all the rules have the threshold value populated in the same way.
  3. Showing information on hover such as rule category.

Please let me know if you have any feedback.

@elkargig
Copy link

Thank you, this looks much better already

@roshan-elastic
Copy link

Let me go and ask @elkargig what he thinks...oh wait - he likes it! :)

Great job @maryam-saeidi - we're also looking to present more sensible defaults in this component in the hosts feature:

Link

image

In this context, we clearly need the host name to show...so we're looking to add it in.

@maryam-saeidi
Copy link
Member Author

@roshan-elastic We can register different alert tables for different purposes with a set of default columns that makes sense in each context. I am refactoring the registration of a new table to make it easier to add a separate one for hosts in this case.

@roshan-elastic
Copy link

ooh amazing @maryam-saeidi !

maryam-saeidi added a commit that referenced this issue Jan 25, 2024
…t columns (#175119)

Closes #174239

## Summary

This PR refactors the alert table registrations and registers a new
alert table for the rule details page. This PR also fixes the SLO
embeddable alert table issue by opening the flyout when the user clicks
on the reason.

Here is the old vs the new table:

|Old alert table|New alert table|
|---|---|

|![image](https://github.com/elastic/kibana/assets/12370520/0289dc2d-b6e8-4727-96fa-b2cf6485e8e5)|![image](https://github.com/elastic/kibana/assets/12370520/226fe529-5ee0-4f5c-9e9f-5ee782c8afe6)|

## 🧪 How to test
- Create some alerts and check the alert table on the alerts page, it
should
    - have 2 hours time range instead of 15 mins
    - show the following fields
        - Triggered
        - Duration
        - Rule name
             - on hover: it shows rule category
        - Group
        - Observed value
        - Threshold
        - Tags
- Check one of the rules page alert tables, it should not show the rule
name column by default
- Create an SLO and check the related alert table embeddable
- Clicking on the reason should show the flyout (this was the fix in
this PR)
   - Everything should work as before

## What will be covered in the future PRs
- [ ] Making sure all rules set the `threshold` field
- [ ] Adding a column with difference (Needs to be discussed with
ResponseOps team)
- [ ] Having source column instead of group by field (Needs to be
discussed with @maciejforcone )
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
…t columns (elastic#175119)

Closes elastic#174239

## Summary

This PR refactors the alert table registrations and registers a new
alert table for the rule details page. This PR also fixes the SLO
embeddable alert table issue by opening the flyout when the user clicks
on the reason.

Here is the old vs the new table:

|Old alert table|New alert table|
|---|---|

|![image](https://github.com/elastic/kibana/assets/12370520/0289dc2d-b6e8-4727-96fa-b2cf6485e8e5)|![image](https://github.com/elastic/kibana/assets/12370520/226fe529-5ee0-4f5c-9e9f-5ee782c8afe6)|

## 🧪 How to test
- Create some alerts and check the alert table on the alerts page, it
should
    - have 2 hours time range instead of 15 mins
    - show the following fields
        - Triggered
        - Duration
        - Rule name
             - on hover: it shows rule category
        - Group
        - Observed value
        - Threshold
        - Tags
- Check one of the rules page alert tables, it should not show the rule
name column by default
- Create an SLO and check the related alert table embeddable
- Clicking on the reason should show the flyout (this was the fix in
this PR)
   - Everything should work as before

## What will be covered in the future PRs
- [ ] Making sure all rules set the `threshold` field
- [ ] Adding a column with difference (Needs to be discussed with
ResponseOps team)
- [ ] Having source column instead of group by field (Needs to be
discussed with @maciejforcone )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants