Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom threshold] Include group by information in the view in app URL #173713

Closed
maryam-saeidi opened this issue Dec 20, 2023 · 1 comment · Fixed by #177016
Closed

[Custom threshold] Include group by information in the view in app URL #173713

maryam-saeidi opened this issue Dec 20, 2023 · 1 comment · Fixed by #177016
Assignees
@maryam-saeidi
Labels
Feature: Custom threshold Observability custom threshold rule type Team:obs-ux-management Observability Management User Experience Team

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Dec 20, 2023 •
edited
Loading

🍒 Summary

In the previous ticket (#171613), we prefilled the data view, time range, and filters (optional and only one aggregation)
In this ticket, we want to add the group by information in the KQL filter.

🎯 Acceptance Criteria

  • Add all the group information to the KQL filter to the view in app URL and check the result in:
    • action variables
    • alert table and flyout
@maryam-saeidi maryam-saeidi added Team:obs-ux-management Observability Management User Experience Team Feature: Custom threshold Observability custom threshold rule type labels Dec 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@maryam-saeidi maryam-saeidi self-assigned this Feb 9, 2024
@maryam-saeidi maryam-saeidi mentioned this issue Feb 15, 2024
Merged
maryam-saeidi added a commit that referenced this issue Feb 22, 2024
@maryam-saeidi
[Custom threshold] Add group by filters to the custom threshold view …
637de1d 
…in app URL (#177016)

Resolves #173713

## Summary

This PR adds group by filters to the view in the app URL for the custom
threshold rule:


![image](https://github.com/elastic/kibana/assets/12370520/c84eecfc-b196-4268-acdd-57bae86ac4c4)

I also moved some types to the common folder and adjusted them to match
the reality.

## 🧪 How to test
- Create a custom threshold rule with group by
   - One with persisted data view
   - One with an ad-hoc data view
- Check the view in app link in the alerts table, you should also see
the group filters there.
- Check the view in app URL from the actions, it should also include the
group filters.
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@maryam-saeidi @fkanout
[Custom threshold] Add group by filters to the custom threshold view …
aff1efe 
…in app URL (elastic#177016)

Resolves elastic#173713

## Summary

This PR adds group by filters to the view in the app URL for the custom
threshold rule:


![image](https://github.com/elastic/kibana/assets/12370520/c84eecfc-b196-4268-acdd-57bae86ac4c4)

I also moved some types to the common folder and adjusted them to match
the reality.

## 🧪 How to test
- Create a custom threshold rule with group by
   - One with persisted data view
   - One with an ad-hoc data view
- Check the view in app link in the alerts table, you should also see
the group filters there.
- Check the view in app URL from the actions, it should also include the
group filters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Feature: Custom threshold Observability custom threshold rule type Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Custom threshold] Add group by filters to the custom threshold view in app URL maryam-saeidi/kibana
2 participants
@maryam-saeidi @elasticmachine