Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Chart switcher with all charts in ES|QL inline editing experience #173222

Closed
Tracked by #174147
timductive opened this issue Dec 12, 2023 · 3 comments
Closed
Tracked by #174147

[ES|QL] Chart switcher with all charts in ES|QL inline editing experience #173222

timductive opened this issue Dec 12, 2023 · 3 comments
Assignees
@mbondyra
Labels
enhancement New value added to drive a business result epic Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timductive
Copy link
Member

The chart switcher in the inline-edit mode for ES|QL should include all charts with better default suggestions.
@timductive timductive added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:ES|QL ES|QL related features in Kibana labels Dec 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula reopened this Dec 18, 2023
@stratoula
Copy link
Contributor

In was using this #163721 to track this but lets keep it separate. I am moving my comment here
I want to raise the priority here for 2 reasons:

  1. We now offer inline editing on all our Lens charts. Instead of having one chart switcher for the XY charts and a generic chart switcher I suggest to merge them in one. I would like to be able to switch among all the different charts that the Lens chart supports.
image
  1. This will be super usefull for ES|QL. Right now we are offering very few suggestions while we could actually allow the users to select among all supported chart types and make the ES|QL usage even more powerful.

I see 2 phases:

Phase 1: Use only the generic chart switcher in the inline editing flyouts
Phase 2: Redesign Lens editor to offer only one switcher.

@stratoula stratoula changed the title [ES|QL] Improve chart suggestions [ES|QL] Chart switcher with all charts in ES|QL inline editing experience Jan 3, 2024
@stratoula stratoula mentioned this issue Jan 3, 2024
Open
@stratoula stratoula assigned mbondyra and unassigned stratoula Feb 7, 2024
@mbondyra mbondyra mentioned this issue Feb 26, 2024
Merged
mbondyra added a commit that referenced this issue Mar 8, 2024
@mbondyra
[ESQL] Add chart switch (#177790)
57f659f 
## Summary

Solves the first part of #173222


Adds chart switcher to ESQL inline Lens editor only (only on Dashbaord):
<img width="303" alt="Screenshot 2024-02-26 at 13 19 41"
src="https://github.com/elastic/kibana/assets/4283304/14f958ed-7c5e-4641-82e0-2638654219a7">
<img width="350" alt="Screenshot 2024-02-26 at 13 19 46"
src="https://github.com/elastic/kibana/assets/4283304/2f2c1ae8-ead1-4535-9a72-7264a780a9c9">

### Very slight design (paddings) changes
<img width="698" alt="Screenshot 2024-02-26 at 13 46 39"
src="https://github.com/elastic/kibana/assets/4283304/2f75403f-5d8e-4d5b-8ea5-df44e09be16a">

Added padding to not cut the icon buttons when hovered:
<img width="810" alt="Screenshot 2024-02-26 at 13 56 02"
src="https://github.com/elastic/kibana/assets/4283304/fbfccbf7-0305-40c2-86ff-7fa148408320">
@stratoula
Copy link
Contributor

closing this as this will be available in 8.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
enhancement New value added to drive a business result epic Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timductive @mbondyra @elasticmachine @stratoula @ninoslavmiskovic