Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Dashboard top nav misaligned in edit mode after user navigates back to dashboard from other nav paths #171682

Closed
bhavyarm opened this issue Nov 21, 2023 · 3 comments
Closed

[Security Solution] Dashboard top nav misaligned in edit mode after user navigates back to dashboard from other nav paths #171682

bhavyarm opened this issue Nov 21, 2023 · 3 comments
Assignees
@angorayc
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features fixed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.12 snapshot

Browser version: chrome latest

Original install method (e.g. download page, yum, from source, etc.): cloud staging

Describe the bug: Dashboard top nav in the security solution is misaligned after user navigates back from actions to dashboard.

Steps to reproduce:

  1. Install sample data
  2. Go to security solutions app - > dashboards -> ->clear the security solutions tag -> open sample logs dashboard -> click on dashboard panel Unique Visitors and click on add to a new case or existing case -> perform the action
  3. There is a notification test case has been updated with view cases link - > click on cases. This will take the user to cases page
View_Case 5. Now click again on dashboards -> open sample logs dashboard 6. Dashboard top nav menu is misaligned. misaligned

Found while testing #167928
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Nov 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@angorayc angorayc assigned angorayc and unassigned stephmilovic Nov 22, 2023
@angorayc angorayc mentioned this issue Jan 25, 2024
Merged
1 task
angorayc added a commit that referenced this issue Jan 25, 2024
@angorayc
[Security Solution] Fix misaligned top nav (#175516)
a8f538d 
## Summary

Issue and steps to reproduce:
#171682

Before:

<img width="1728" alt="misaligned"
src="https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047">


After:


https://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1




### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@angorayc angorayc added the fixed label Jan 25, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 25, 2024
@angorayc
[Security Solution] Fix misaligned top nav (elastic#175516)
5f56cdd 
## Summary

Issue and steps to reproduce:
elastic#171682

Before:

<img width="1728" alt="misaligned"
src="https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047">

After:

https://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit a8f538d)
kibanamachine added a commit that referenced this issue Jan 25, 2024
@kibanamachine @angorayc
[8.12] [Security Solution] Fix misaligned top nav (#175516) (#175532)
836d11c 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Security Solution] Fix misaligned top nav
(#175516)](#175516)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-25T12:39:12Z","message":"[Security
Solution] Fix misaligned top nav (#175516)\n\n## Summary\r\n\r\nIssue
and steps to
reproduce:\r\nhttps://github.com//issues/171682\r\n\r\nBefore:\r\n\r\n<img
width=\"1728\"
alt=\"misaligned\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047\">\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a8f538d15cc40be82bf5abf697a94ee2a5f0466f","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat
Hunting","Team:Threat Hunting:Explore","Feature:Security
Dashboards","v8.12.1","v8.13.0"],"title":"[Security Solution] Fix
misaligned top
nav","number":175516,"url":"https://github.com/elastic/kibana/pull/175516","mergeCommit":{"message":"[Security
Solution] Fix misaligned top nav (#175516)\n\n## Summary\r\n\r\nIssue
and steps to
reproduce:\r\nhttps://github.com//issues/171682\r\n\r\nBefore:\r\n\r\n<img
width=\"1728\"
alt=\"misaligned\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047\">\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a8f538d15cc40be82bf5abf697a94ee2a5f0466f"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175516","number":175516,"mergeCommit":{"message":"[Security
Solution] Fix misaligned top nav (#175516)\n\n## Summary\r\n\r\nIssue
and steps to
reproduce:\r\nhttps://github.com//issues/171682\r\n\r\nBefore:\r\n\r\n<img
width=\"1728\"
alt=\"misaligned\"\r\nsrc=\"https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047\">\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a8f538d15cc40be82bf5abf697a94ee2a5f0466f"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
@MadameSheema
Copy link
Member

@bhavyarm the issue should be fixed on 8.13BC1. Do you mind validating it as soon as the BC is ready? Thanks :)

CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@angorayc @CoenWarmer
[Security Solution] Fix misaligned top nav (elastic#175516)
b71a2e4 
## Summary

Issue and steps to reproduce:
elastic#171682

Before:

<img width="1728" alt="misaligned"
src="https://github.com/elastic/kibana/assets/7074629/6c0f8484-7bfb-4329-9029-b53a3c118047">


After:


https://github.com/elastic/kibana/assets/6295984/58d3e5bc-0a9a-475b-99dd-00e061b8c4b1




### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features fixed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team
Projects
Security Bug Audit
Status: To do
Milestone
No milestone
Development

No branches or pull requests
6 participants
@angorayc @stephmilovic @bhavyarm @elasticmachine @MadameSheema @kibanamachine