Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUX] Make serverless sidenav show/hide Hosts depending on settings toggle #169198

Closed
mykolaharmash opened this issue Oct 18, 2023 · 3 comments · Fixed by #170035
Closed

[ObsUX] Make serverless sidenav show/hide Hosts depending on settings toggle #169198

mykolaharmash opened this issue Oct 18, 2023 · 3 comments · Fixed by #170035
Assignees
@mykolaharmash
Labels
Feature:Metrics UI Metrics UI feature Project:Serverless Work as part of the Serverless project for its initial release Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@mykolaharmash
Copy link
Contributor

mykolaharmash commented Oct 18, 2023 •
edited
Loading

Follow up to #167062

We need to Implement logic to hide/show Hosts sidenav item in serverless when we toggle the Hosts setting in both Advanced Settings and Infra Settings.

Implementation hint.
Hosts setting OBSERVABILITY_ENABLE_INFRASTRUCTURE_HOSTS_VIEW_ID should first be added to the observability settings allow-list
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 18, 2023
@mykolaharmash mykolaharmash added Feature:Metrics UI Metrics UI feature Project:Serverless Work as part of the Serverless project for its initial release and removed needs-team Issues missing a team label labels Oct 18, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 18, 2023
@mykolaharmash mykolaharmash mentioned this issue Oct 18, 2023
Closed
@mykolaharmash mykolaharmash added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Oct 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 18, 2023
@neptunian
Copy link
Contributor

Hi @mykolaharmash Is this a dup of #168853 ?

@mykolaharmash mykolaharmash changed the title [ObsUX] Enable Hosts advanced setting in serverless [ObsUX] Make serverless sidenav show/hide Hosts depending on settings toggle Oct 19, 2023
@mykolaharmash
Copy link
Contributor Author

Hi @mykolaharmash Is this a dup of #168853 ?

Hi @neptunian, this one was supposed to be only about the allow list and serverless sidenav, but you're right, there is too much overlap. I've changed this issue only to be about serverless sidenav and #168853 will cover the allow list thing and enabling infra in general.

@mykolaharmash mykolaharmash self-assigned this Oct 24, 2023
@mykolaharmash mykolaharmash mentioned this issue Oct 27, 2023
Merged
mykolaharmash added a commit that referenced this issue Oct 30, 2023
@mykolaharmash
[ObsUX] Enable Hosts advanced setting on serverless (#170035)
e804ef2 
Closes #169198

## Summary

* Adds Hosts advanced setting to the observability settings allowlist
* Adds tests for Hosts sidenav item visibility


https://github.com/elastic/kibana/assets/793851/3c9252c8-a4cb-4da8-aa60-23a8aeb60d4c

# How to test

* Run locally in serverless mode
* Make sure "Observability Hosts view" toggle is visible on the Advanced
Settings screen
* Toggle the setting on and off, make sure sidenav properly reacts to
the changes
* Go to Infra settings screen
* Toggle the same setting on and off, and also make sure sidenav
properly reacts to the changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mykolaharmash mykolaharmash

Labels
Feature:Metrics UI Metrics UI feature Project:Serverless Work as part of the Serverless project for its initial release Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ObsUX] Enable Hosts advanced setting on serverless mykolaharmash/kibana
3 participants
@mykolaharmash @neptunian @elasticmachine