Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] do not allow to save incorrect state in inline editing #168445

Closed
mbondyra opened this issue Oct 10, 2023 · 1 comment · Fixed by #172819
Closed

[Lens] do not allow to save incorrect state in inline editing #168445

mbondyra opened this issue Oct 10, 2023 · 1 comment · Fixed by #172819
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Oct 10, 2023 •
edited
Loading

Describe the feature:
When editing a Lens visualization from the dashboard, we can input incorrect state and save it. After refreshing the visualization is not showing.

The good idea would be to disable 'save' button when the state is incorrect.

Screenshot 2023-10-10 at 11 56 18
@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Oct 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra self-assigned this Oct 13, 2023
@mbondyra mbondyra mentioned this issue Oct 16, 2023
Closed
9 tasks
@mbondyra mbondyra removed their assignment Dec 5, 2023
@mbondyra mbondyra mentioned this issue Dec 7, 2023
Merged
mbondyra added a commit that referenced this issue Jan 4, 2024
@mbondyra @stratoula
[Lens] do not allow to save incorrect state in inline Lens editor (#1…
f8f0d87 
…72819)

## Summary

Fixes #168445

We follow the approach:
1. if we can render we are able to save even with errors
2. If we cannot render, we cannot save

There are 3 cases we have to think when approaching this task. 

1. When the error comes from the request (for example, incorrect KQL in
'filter by' or wrong response from ES)
We don't catch those cases in Lens app so I didn't fix it here either.
It would be very difficult to do so.

2. When the chart cannot be rendered
(whether there's a missing dimension or errors stop the expression to be
generated)
<img width="524" alt="Screenshot 2023-10-16 at 13 30 32"
src="https://github.com/elastic/kibana/assets/4283304/9ecafcd8-7a70-45b8-babe-ca65bc1e4903">

3. When the chart has errors but can be rendered
We allow saving in this case.

<img width="381" alt="Screenshot 2023-10-17 at 15 02 47"
src="https://github.com/elastic/kibana/assets/4283304/d2358ef7-d7b7-4cbf-8532-0caa60d73008">

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
2 participants
@mbondyra @elasticmachine